[Autofill] Autofill fails to show suggestions for credit card split across fields.

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
+#include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/tuple.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/credit_card.h"
@@ skipping 863 matching lines @@
 // Test that we return only matching credit card profile suggestions when the
 // selected form field has been partially filled out.
 TEST_F(AutofillManagerTest, GetCreditCardSuggestionsMatchCharacter) {
   // Set up our form data.
   FormData form;
   CreateTestCreditCardFormData(&form, true, false);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   FormFieldData field;
-  test::CreateTestFormField("Card Number", "cardnumber", "4", "text", &field);
+  test::CreateTestFormField("Card Number", "cardnumber", "78", "text", &field);
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   // Test that we sent the right values to the external delegate.
   base::string16 expected_values[] = {ASCIIToUTF16("************3456")};
   base::string16 expected_labels[] = {ASCIIToUTF16("04/12")};
   base::string16 expected_icons[] = {ASCIIToUTF16(kVisaCard)};
@@ skipping 2069 matching lines @@
   FormData form;
   test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);  // should call the delegate's OnQuery()
 
   EXPECT_TRUE(external_delegate_->on_query_seen());
 }
 
+// Test to verify suggestions appears for forms having credit card number split
+// across fields.
+TEST_F(AutofillManagerTest, GetCreditCardSuggestionsForNumberSpitAcrossFields) {
+  // Set up our form data with credit card number split across fields.
+  FormData form;
+  CreateTestCreditCardFormData(&form, true, false);

[Ilya Sherman, 2014/10/30 22:58:55]

Please remove this call as well, and instead construct the exact form you want
for this test.  That's clearer than constructing a form that's similar to what
you want, and then erasing and inserting fields based on indices.

[Pritam Nikam, 2014/10/31 06:59:33]

Done.

+
+  // Remove existing card number field.
+  form.fields.erase(form.fields.begin() + 1);
+
+  // Add new 4 |card_number_field|s to the |form|.
+  FormFieldData card_number_field;
+  card_number_field.max_length = 4;
+  test::CreateTestFormField(
+      "Card Number", "cardnumber_1", "", "text", &card_number_field);
+  form.fields.insert(form.fields.begin() + 1, card_number_field);
+
+  test::CreateTestFormField("", "cardnumber_2", "", "text", &card_number_field);
+  form.fields.insert(form.fields.begin() + 2, card_number_field);
+
+  test::CreateTestFormField("", "cardnumber_3", "", "text", &card_number_field);
+  form.fields.insert(form.fields.begin() + 3, card_number_field);
+
+  test::CreateTestFormField("", "cardnumber_4", "", "text", &card_number_field);
+  form.fields.insert(form.fields.begin() + 4, card_number_field);
+
+  std::vector<FormData> forms(1, form);
+  FormsSeen(forms);
+
+  // Fill the credit card details.

[Ilya Sherman, 2014/10/30 22:58:55]

I'm still not sure why you're filling the form as part of this test.  I'd prefer
to have a more focused test, which just verifies that suggestions are shown
correctly.  If you also want to test filling, then please move that to a
separate test (but I think we already have coverage for the filling case -- do
we not?)

[Pritam Nikam, 2014/10/31 06:59:33]

Yes, you are right, we do have testcases for the filling case.

Sorry if I didn't elaborate the problem correctly. The issue here
(http://crbug.com/420323, snapshots attached for ref.), is to populate
suggestions for one of the middle credit card number fields when autofilled
already. If field is empty (not autofilled) then there is no problem to get the
autofill suggestions. I would say filled card number field is the per-condition
here.

Thats the reason the test needs field to be filled first, and the try to
populate the suggestions.

In other words, without this patch (that is sub-string matching instead of
pre-fix matching for card number field), this test shall fail.

[Ilya Sherman, 2014/10/31 22:49:59]

Hmm, do we really need the field to be autofilled?  I thought we just needed the
field to have a (partial) value entered.  Am I misunderstanding what bug you are
trying to fix?

+  GUIDPair guid("00000000-0000-0000-0000-000000000004", 0);
+  GUIDPair empty(std::string(), 0);
+  int response_page_id = 0;
+  FormData response_data;
+  FillAutofillFormDataAndSaveResults(kDefaultPageID,
+                                     form,
+                                     *form.fields.begin(),
+                                     PackGUIDs(guid, empty),
+                                     &response_page_id,
+                                     &response_data);
+
+  ASSERT_EQ(7U, response_data.fields.size());
+
+  // Verify whether suggestions are populated correctly for one of the middle
+  // credit card number fields.
+  FormFieldData number_field = response_data.fields[3];
+
+  // Suggested card number 4234-5678-9012-3456.
+  EXPECT_TRUE(StartsWith(number_field.value, ASCIIToUTF16("9012"), false));
+
+  // Get the suggestions for credit card |number_field|.
+  GetAutofillSuggestions(form, number_field);
+
+  // No suggestions provided, so send an empty vector as the results.
+  // This triggers the combined message send.
+  AutocompleteSuggestionsReturned(std::vector<base::string16>());
+
+  base::string16 expected_values[] = {ASCIIToUTF16("************3456")};
+  base::string16 expected_labels[] = {ASCIIToUTF16("04/12")};
+  base::string16 expected_icons[] = {ASCIIToUTF16(kVisaCard)};
+  int expected_unique_ids[] = {autofill_manager_->GetPackedCreditCardID(4)};
+  external_delegate_->CheckSuggestions(kDefaultPageID,
+                                       arraysize(expected_values),
+                                       expected_values,
+                                       expected_labels,
+                                       expected_icons,
+                                       expected_unique_ids);
+}
+
 }  // namespace autofill