Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 622773002: [Autofill] Autofill fails to show suggestions for credit card split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed ObfuscatedCreditCardNumber() from AutofillManager. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 const FormFieldData& field, 258 const FormFieldData& field,
259 const AutofillField& autofill_field, 259 const AutofillField& autofill_field,
260 std::vector<base::string16>* values, 260 std::vector<base::string16>* values,
261 std::vector<base::string16>* labels, 261 std::vector<base::string16>* labels,
262 std::vector<base::string16>* icons, 262 std::vector<base::string16>* icons,
263 std::vector<int>* unique_ids) const; 263 std::vector<int>* unique_ids) const;
264 264
265 // Returns a list of values from the stored credit cards that match |type| and 265 // Returns a list of values from the stored credit cards that match |type| and
266 // the value of |field| and returns the labels of the matching credit cards. 266 // the value of |field| and returns the labels of the matching credit cards.
267 void GetCreditCardSuggestions(const FormFieldData& field, 267 void GetCreditCardSuggestions(const FormFieldData& field,
268 const AutofillType& type, 268 const AutofillField& autofill_field,
269 std::vector<base::string16>* values, 269 std::vector<base::string16>* values,
270 std::vector<base::string16>* labels, 270 std::vector<base::string16>* labels,
271 std::vector<base::string16>* icons, 271 std::vector<base::string16>* icons,
272 std::vector<int>* unique_ids) const; 272 std::vector<int>* unique_ids) const;
273 273
274 // Parses the forms using heuristic matching and querying the Autofill server. 274 // Parses the forms using heuristic matching and querying the Autofill server.
275 void ParseForms(const std::vector<FormData>& forms); 275 void ParseForms(const std::vector<FormData>& forms);
276 276
277 // Imports the form data, submitted by the user, into |personal_data_|. 277 // Imports the form data, submitted by the user, into |personal_data_|.
278 void ImportFormData(const FormStructure& submitted_form); 278 void ImportFormData(const FormStructure& submitted_form);
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 375 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
376 AutocompleteOffRespected); 376 AutocompleteOffRespected);
377 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 377 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
378 AutocompleteOffRespectedWithFlag); 378 AutocompleteOffRespectedWithFlag);
379 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 379 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
380 }; 380 };
381 381
382 } // namespace autofill 382 } // namespace autofill
383 383
384 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 384 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698