[Autofill] Autofill fails to show suggestions for credit card split across fields.

components/autofill/core/browser/autofill_field_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_field.h"
 
 #include "base/format_macros.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 604 matching lines @@
   AutofillField::FillFormField(cc_number_full,
                                ASCIIToUTF16(test.card_number_),
                                "en-US",
                                "en-US",
                                &cc_number_full);
 
   // Verify for expected results.
   EXPECT_EQ(ASCIIToUTF16(test.card_number_), cc_number_full.value);
 }
 
+TEST(AutofillFieldTest, GetCreditCardNumberValue) {
+  std::string card_number("5187654321098765");
+  std::string expectations[] = {"5187", "6543", "2109", "8765"};
+  size_t total_spilts = 4;

[Ilya Sherman, 2014/10/13 23:33:37]

nit: Please use the arraysize macro to compute this.

[Pritam Nikam, 2014/10/15 09:12:11]

Done.

+  int max_lengths[] = {4, 4, 4, 4};
+
+  for (size_t i = 0; i < total_spilts; ++i) {
+    AutofillField cc_number_part;
+    cc_number_part.set_heuristic_type(CREDIT_CARD_NUMBER);
+    cc_number_part.max_length = max_lengths[i];
+    cc_number_part.set_credit_card_number_offset(4 * i);
+
+    // Retrive the value for |cc_number_part|.
+    base::string16 actual = AutofillField::GetCreditCardNumberValue(
+        cc_number_part, ASCIIToUTF16(card_number));
+
+    // Enforce the field's |max_length| constrain.

[Ilya Sherman, 2014/10/13 23:33:37]

nit: "constrain" -> "constraint".  Also, please mention that normally this would
be handled by the renderer, which is why it needs to be specially handled in the
unit test.

[Pritam Nikam, 2014/10/15 09:12:10]

Done.

+    actual = actual.substr(0, max_lengths[i]);
+
+    // Verify for expected results.
+    EXPECT_EQ(ASCIIToUTF16(expectations[i]), actual);
+  }
+}

[Ilya Sherman, 2014/10/13 23:33:37]

Please also test the behavior if the offset is equal to the credit card number
in size, or larger than it.

[Pritam Nikam, 2014/10/15 09:12:10]

Done.

+
 }  // namespace
 }  // namespace autofill