Update libva headers to the latest release (1.2.1).

Update libva headers to the latest release (1.2.1).

The motivation is to pick up upstream fixes and be compatible with
new VAAPI library after release 1.2.0: the function vaCreateSurfaces()
changes its prototype in API version >= 0.34, so we need to handle this
in run time.

The commands used to update third_party/libva/va are:
git clone git://anongit.freedesktop.org/libva /tmp/libva
cd /tmp/libva
git checkout libva-1.2.1
rm -rf ~/chromium/src/third_party/libva/va
find va -name \*.h -exec cp --parents \{\} ~/chromium/src/third_party/libva \;
cp ~/va_version.h ~/chromium/src/third_party/libva/va

BUG=none
TEST=on link, run through the H.264.1 conformance bitstreams, and no regression.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236492

[chihchung, 2013-11-18 11:50:13]

Hi,

This is in preparation to upgrade libva/libva-intel-driver in ChromeOS to 1.2.1
(because there is some binary interface incompatibility). All files in
third_party/libva/va/ are just copied directly from upstream git. Other than
that, only two small changes are needed to handle the incompatibility:

M 	content/common/gpu/media/vaapi_wrapper.h
M 	content/common/gpu/media/vaapi_wrapper.cc 

checklicenses.py complains about unknown license for two files
(wayland-drm-client-protocol.h and va_egl.h). Should I add exceptions for them
or just remove those two files? (they are not used).

Thanks,
Chih-Chung Chang

[Ami GONE FROM CHROMIUM, 2013-11-20 23:36:45]

On 2013/11/18 11:50:13, chihchung wrote:
> Hi,
> 
> This is in preparation to upgrade libva/libva-intel-driver in ChromeOS to
1.2.1
> (because there is some binary interface incompatibility). 

Please add a TODO to the conditional code in vaapi_wrapper.cc to drop the old
path once cros updates to 1.2.1.

> checklicenses.py complains about unknown license for two files
> (wayland-drm-client-protocol.h and va_egl.h). Should I add exceptions for them
> or just remove those two files? (they are not used).

You should not add exceptions.  Upstream has been pretty responsive about fixing
their license headers in the past so that should be your first move.  If we
don't need the files, it's also fine with me to drop them from the chromium copy
(though you should still ping upstream, for future rolls).

Modulo these nits, LGTM.

[Pawel Osciak, 2013-11-21 05:36:36]

lgtm for vaapi wrapper.

https://codereview.chromium.org/62273006/diff/1/content/common/gpu/media/vaap...
File content/common/gpu/media/vaapi_wrapper.cc (right):

https://codereview.chromium.org/62273006/diff/1/content/common/gpu/media/vaap...
content/common/gpu/media/vaapi_wrapper.cc:61: /* In VAAPI version < 0.34,
vaCreateSurface has 6 parameters, but in VAAPI
Please use // style comments (both are allowed, but we should be consistent). I
guess this is a short-lived patch, but just for the future.

[chihchung, 2013-11-21 06:45:18]

Removed two header files and reopened the header license bug in upstream.

https://codereview.chromium.org/62273006/diff/1/content/common/gpu/media/vaap...
File content/common/gpu/media/vaapi_wrapper.cc (right):

https://codereview.chromium.org/62273006/diff/1/content/common/gpu/media/vaap...
content/common/gpu/media/vaapi_wrapper.cc:61: /* In VAAPI version < 0.34,
vaCreateSurface has 6 parameters, but in VAAPI
On 2013/11/21 05:36:36, posciak wrote:
> Please use // style comments (both are allowed, but we should be consistent).
I
> guess this is a short-lived patch, but just for the future.

Done.

https://codereview.chromium.org/62273006/diff/70001/content/common/gpu/media/...
File content/common/gpu/media/vaapi_wrapper.cc (right):

https://codereview.chromium.org/62273006/diff/70001/content/common/gpu/media/...
content/common/gpu/media/vaapi_wrapper.cc:63: // TODO(chihchung): Remove the old
path once ChromeOS updates to 1.2.1.
TODO Added.

[commit-bot: I haz the power, 2013-11-21 06:45:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chihchung@chromium.org/62273006/70001

[commit-bot: I haz the power, 2013-11-21 11:03:18]

Change committed as 236492