Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 62273005: CQ: catch more exceptions when looking for new pending changes. (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.
Modified:
7 years, 1 month ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

CQ: catch more exceptions when looking for new pending changes. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=235490

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M commit-queue/pending_manager.py View 1 3 chunks +37 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-16 01:27:37 UTC) #1
Ryan Tseng
Comments about making errors more verbose below https://codereview.chromium.org/62273005/diff/1/commit-queue/pending_manager.py File commit-queue/pending_manager.py (right): https://codereview.chromium.org/62273005/diff/1/commit-queue/pending_manager.py#newcode204 commit-queue/pending_manager.py:204: logging.warning(str(e)) logging.warning('%s ...
7 years, 1 month ago (2013-11-16 01:38:36 UTC) #2
Paweł Hajdan Jr.
Done, PTAL.
7 years, 1 month ago (2013-11-16 01:43:58 UTC) #3
Ryan Tseng
Looks innocuous enough, lgtm. Out of principle, be careful if you're going to land it ...
7 years, 1 month ago (2013-11-16 01:48:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/62273005/50001
7 years, 1 month ago (2013-11-16 01:49:28 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-16 01:49:43 UTC) #6
Message was sent while issue was closed.
Change committed as 235490

Powered by Google App Engine
This is Rietveld 408576698