Issue 622713003: Skip test on all architectures but arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 622713003: Skip test on all architectures but arm. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach

Modified:
6 years, 2 months ago

Reviewers:
Benedikt Meurer, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Skip test on all architectures but arm. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24385

Patch Set 1 #

Total comments: 2

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	test/mjsunit/mjsunit.status	View		1 chunk	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

Committed patchset #1 (id:1) manually as 24385 (presubmit successful).

6 years, 2 months ago (2014-10-02 08:38:03 UTC) #4

Jakob Kummerow

6 years, 2 months ago (2014-10-02 09:00:25 UTC) #6

Message was sent while issue was closed.

DBC.

https://codereview.chromium.org/622713003/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):

https://codereview.chromium.org/622713003/diff/1/test/mjsunit/mjsunit.status#...
test/mjsunit/mjsunit.status:199: 'nans': [PASS, ],
wut? Just remove the expectation! Or was this an accidental edit?

https://codereview.chromium.org/622713003/diff/1/test/mjsunit/mjsunit.status#...
test/mjsunit/mjsunit.status:202: 'math-floor-of-div-nosudiv': [PASS, SLOW,
['arch not in [arm, arm64, android_arm, android_arm64]', SKIP]],
AFAIK sdiv/udiv are always available on arm64, so the list should be [arm,
android_arm].

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages