Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 622683004: [fsp] Remove unused tests. (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
hirono
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Remove unused tests. TEST=Not affected. BUG=None Committed: https://crrev.com/8c5bc546c307d749fa7facb3d1df93e04fc90344 Cr-Commit-Position: refs/heads/master@{#297796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -180 lines) Patch
D chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 1 chunk +0 lines, -180 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
mtomasz
@hirono: PTAL. Thanks.
6 years, 2 months ago (2014-10-02 04:07:57 UTC) #2
hirono
Why is the test not used? The corresponding code was removed?
6 years, 2 months ago (2014-10-02 08:17:19 UTC) #3
mtomasz
On 2014/10/02 08:17:19, hirono wrote: > Why is the test not used? The corresponding code ...
6 years, 2 months ago (2014-10-02 08:19:55 UTC) #4
hirono
Got it, thanks! lgtm!
6 years, 2 months ago (2014-10-02 08:21:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622683004/1
6 years, 2 months ago (2014-10-02 08:23:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14939)
6 years, 2 months ago (2014-10-02 08:30:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622683004/1
6 years, 2 months ago (2014-10-02 10:12:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 41379813a550fefb6fdb96ed09c9643e0e733b6b
6 years, 2 months ago (2014-10-02 10:15:48 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 10:16:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c5bc546c307d749fa7facb3d1df93e04fc90344
Cr-Commit-Position: refs/heads/master@{#297796}

Powered by Google App Engine
This is Rietveld 408576698