Issue 622683002: ThreadWatcher - Disarm the StartupTimeBomb, if we haven't started

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 622683002: ThreadWatcher - Disarm the StartupTimeBomb, if we haven't started (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)

Modified:
6 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_disk_cache

Project:
chromium

Visibility:
Public.

ThreadWatcher - Disarm the StartupTimeBomb, if we haven't started ThreadWacther (for example, WatchDog thread is not started in Debug mode - CL: https://codereview.chromium.org/573683003/). R=sky@chromium.org Committed: https://crrev.com/dd42a54082d3be7d7a667092b1eab98e127ae2ca Cr-Commit-Position: refs/heads/master@{#297747}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	chrome/browser/metrics/thread_watcher.cc	View		2 chunks	+11 lines, -7 lines	0 comments	Download

Total messages: 6 (1 generated)

ramant (doing other things)

Hi sky, StartupTimeBomb was going off in debug mode. We have never disabled it because ...

6 years, 2 months ago (2014-10-01 21:25:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622683002/1

6 years, 2 months ago (2014-10-01 21:40:45 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as c727e6ce5a7491880c9940b345502f6820cb5984

6 years, 2 months ago (2014-10-02 00:29:38 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-02 00:30:43 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dd42a54082d3be7d7a667092b1eab98e127ae2ca
Cr-Commit-Position: refs/heads/master@{#297747}