Source/core/rendering/RenderText.cpp - Issue 622653002: Force ComplexPath if any part of the node requires it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderText.cpp

Issue 622653002: Force ComplexPath if any part of the node requires it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/text/international/complex-text-with-default-font-spaces-expected.html ('k') | Source/core/rendering/line/BreakingContextInlineHeaders.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderText.cpp

diff --git a/Source/core/rendering/RenderText.cpp b/Source/core/rendering/RenderText.cpp

index 231b291e47e27177996cb70afad0a4dda7b87f79..871a8c9a6d32a2e5051cd3019664830d645171f0 100644

--- a/Source/core/rendering/RenderText.cpp

+++ b/Source/core/rendering/RenderText.cpp

@@ -928,7 +928,6 @@ void RenderText::computePreferredLogicalWidths(float leadWidth, HashSet<const Si

TextRun textRun(text());

BidiResolver<TextRunIterator, BidiCharacterRun> bidiResolver;

BidiCharacterRun* run;

TextDirection textDirection = styleToUse->direction();

if (isOverride(styleToUse->unicodeBidi())) {

@@ -1107,6 +1106,7 @@ void RenderText::computePreferredLogicalWidths(float leadWidth, HashSet<const Si

} else {

TextRun run = constructTextRun(this, f, this, i, 1, styleToUse, textDirection);

run.setCharactersLength(len - i);

+ run.setUseComplexCodePath(!canUseSimpleFontCodePath());

ASSERT(run.charactersLength() >= run.length());

run.setTabSize(!style()->collapseWhiteSpace(), style()->tabSize());

run.setXPos(leadWidth + currMaxWidth);