mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl - Issue 622593002: mojo: Allow circular dependencies between structs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 622593002: mojo: Allow circular dependencies between structs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_python_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

index 634c7cd5e254fc8aef8e339ae71b29865a322fcf..c0b2e3e2697a47dceea713982a0a024c873a0e6f 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

@@ -38,6 +38,10 @@

{{kind.value_kind|get_map_validate_params|indent(10)}}>(

mojo::internal::DecodePointerRaw(&object->{{name}}.offset),

bounds_checker)) {

+{%- elif kind|is_struct_kind %}

+ if (!{{kind|get_name_for_kind}}::Data_::Validate(

+ mojo::internal::DecodePointerRaw(&object->{{name}}.offset),

+ bounds_checker)) {

{%- else %}

if (!{{wrapper_type}}::Data_::Validate(

mojo::internal::DecodePointerRaw(&object->{{name}}.offset),