Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: mojo/public/cpp/bindings/lib/array_serialization.h

Issue 622593002: mojo: Allow circular dependencies between structs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/lib/bindings_internal.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/array_serialization.h
diff --git a/mojo/public/cpp/bindings/lib/array_serialization.h b/mojo/public/cpp/bindings/lib/array_serialization.h
index 41532388ac212a531c0a840eb6a544dcf3eb3fa8..e73553d89b39a6f2ba4142cd6e83ffec769a3acb 100644
--- a/mojo/public/cpp/bindings/lib/array_serialization.h
+++ b/mojo/public/cpp/bindings/lib/array_serialization.h
@@ -132,12 +132,20 @@ struct ArraySerializer<ScopedHandleBase<H>, H, true> {
}
};
+// This template must only apply to pointer mojo entity (structs and arrays).
+// This is done by ensuring that WrapperTraits<S>::DataType is a pointer.
template <typename S>
-struct ArraySerializer<S, typename S::Data_*, true> {
+struct ArraySerializer<S,
+ typename internal::EnableIf<
+ internal::IsPointer<typename internal::WrapperTraits<
+ S>::DataType>::value,
+ typename internal::WrapperTraits<S>::DataType>::type,
+ true> {
+ typedef typename internal::RemovePointer<
+ typename internal::WrapperTraits<S>::DataType>::type S_Data;
static size_t GetSerializedSize(const Array<S>& input) {
- size_t size =
- sizeof(Array_Data<typename S::Data_*>) +
- input.size() * sizeof(internal::StructPointer<typename S::Data_>);
+ size_t size = sizeof(Array_Data<S_Data*>) +
+ input.size() * sizeof(internal::StructPointer<S_Data>);
for (size_t i = 0; i < input.size(); ++i)
size += GetSerializedSize_(input[i]);
return size;
@@ -145,9 +153,9 @@ struct ArraySerializer<S, typename S::Data_*, true> {
template <bool element_is_nullable, typename ElementValidateParams>
static void SerializeElements(Array<S> input,
Buffer* buf,
- Array_Data<typename S::Data_*>* output) {
+ Array_Data<S_Data*>* output) {
for (size_t i = 0; i < input.size(); ++i) {
- typename S::Data_* element;
+ S_Data* element;
SerializeCaller<S, ElementValidateParams>::Run(
input[i].Pass(), buf, &element);
output->at(i) = element;
@@ -158,7 +166,7 @@ struct ArraySerializer<S, typename S::Data_*, true> {
"null in array expecting valid pointers", input.size(), i));
}
}
- static void DeserializeElements(Array_Data<typename S::Data_*>* input,
+ static void DeserializeElements(Array_Data<S_Data*>* input,
Array<S>* output) {
Array<S> result(input->size());
for (size_t i = 0; i < input->size(); ++i) {
@@ -172,7 +180,9 @@ struct ArraySerializer<S, typename S::Data_*, true> {
private:
template <typename T, typename Params>
struct SerializeCaller {
- static void Run(T input, Buffer* buf, typename T::Data_** output) {
+ static void Run(T input,
+ Buffer* buf,
+ typename internal::WrapperTraits<T>::DataType* output) {
static_assert((IsSame<Params, NoValidateParams>::value),
"Struct type should not have array validate params");
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/lib/bindings_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698