Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 622513002: Create a cache file before mounting zip file. (Closed)

Created:
6 years, 2 months ago by hirono
Modified:
6 years, 2 months ago
Reviewers:
kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Create a cache file before mounting zip file. Previusly JavaScript send a request to create a cache file before mounting zip file, but the code was recently removed. This CL adds lines to create a cache to the API for mouting a zip file. BUG=419285 TEST=repro steps on the bug Committed: https://crrev.com/cf841063b6b7cfbfb40945a75a72e592b3fe6169 Cr-Commit-Position: refs/heads/master@{#297622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc View 2 chunks +34 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL the CL? Thank you!
6 years, 2 months ago (2014-10-01 09:20:53 UTC) #2
kinaba
On 2014/10/01 09:20:53, hirono wrote: > PTAL the CL? Thank you! lgtm. sorry i couldn't ...
6 years, 2 months ago (2014-10-01 09:48:38 UTC) #3
hirono
On 2014/10/01 09:48:38, kinaba wrote: > On 2014/10/01 09:20:53, hirono wrote: > > PTAL the ...
6 years, 2 months ago (2014-10-01 09:56:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622513002/1
6 years, 2 months ago (2014-10-01 09:57:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as b370a9c5f877bc50f0fb617f58954eabd9f297cc
6 years, 2 months ago (2014-10-01 10:32:51 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 10:33:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf841063b6b7cfbfb40945a75a72e592b3fe6169
Cr-Commit-Position: refs/heads/master@{#297622}

Powered by Google App Engine
This is Rietveld 408576698