Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 622443002: Subzero: Change llvm::OwningPtr to C++11's std::unique_ptr. (Closed)

Created:
6 years, 2 months ago by Jim Stichnoth
Modified:
6 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Change llvm::OwningPtr to C++11's std::unique_ptr. While I'm at it, normalize the #include order: 1. C++ library headers 2. LLVM headers 3. Subzero headers A blank line between each group. Each group sorted alphabetically, case-insensitive. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3930 R=jfb@chromium.org, jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a18cc9c60a032e4a02ea0aef08bc758e5acb4cd0

Patch Set 1 #

Patch Set 2 : Remove ErrorOr for now #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -67 lines) Patch
M src/IceCfg.h View 2 chunks +9 lines, -9 lines 0 comments Download
M src/IceCfg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceConverter.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M src/IceDefs.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/IceGlobalContext.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceLiveness.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceRNG.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceTargetLowering.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/IceTargetLowering.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M src/IceTranslator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceTranslator.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M src/IceTypeConverter.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceTypeConverter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/PNaClTranslator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/PNaClTranslator.cpp View 1 3 chunks +13 lines, -11 lines 2 comments Download
M src/llvm2ice.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
https://codereview.chromium.org/622443002/diff/20001/src/PNaClTranslator.cpp File src/PNaClTranslator.cpp (right): https://codereview.chromium.org/622443002/diff/20001/src/PNaClTranslator.cpp#newcode2383 src/PNaClTranslator.cpp:2383: OwningPtr<MemoryBuffer> MemBuf; The obvious OwningPtr-->std::unique_ptr doesn't work here. JF ...
6 years, 2 months ago (2014-10-01 00:36:49 UTC) #2
JF
lgtm https://codereview.chromium.org/622443002/diff/20001/src/PNaClTranslator.cpp File src/PNaClTranslator.cpp (right): https://codereview.chromium.org/622443002/diff/20001/src/PNaClTranslator.cpp#newcode2383 src/PNaClTranslator.cpp:2383: OwningPtr<MemoryBuffer> MemBuf; On 2014/10/01 00:36:49, stichnot wrote: > ...
6 years, 2 months ago (2014-10-01 01:18:35 UTC) #3
jvoung (off chromium)
lgtm
6 years, 2 months ago (2014-10-01 01:49:36 UTC) #4
Jim Stichnoth
6 years, 2 months ago (2014-10-01 02:10:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a18cc9c60a032e4a02ea0aef08bc758e5acb4cd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698