Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 622373003: Replacing the OVERRIDE with override in chrome/common (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override in chrome/common This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/71dbed12744212997f7e9c6ab09d3ff3c2a4d4fc Cr-Commit-Position: refs/heads/master@{#298506}

Patch Set 1 #

Patch Set 2 : Resolved the build error #

Patch Set 3 : Resolved Error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -156 lines) Patch
M chrome/common/chrome_content_client.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/common/crash_keys_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/identity/oauth2_manifest_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/input_ime/input_components_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/omnibox/omnibox_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/plugins/plugins_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/speech/tts_engine_manifest_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/spellcheck/spellcheck_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/storage/storage_schema_manifest_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/supervised_user_private/supervised_user_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/system_indicator/system_indicator_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/url_handlers/url_handlers_parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.h View 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/common/extensions/features/chrome_channel_feature_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/app_isolation_info.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/app_launch_info.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/automation.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/automation.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/extension_action_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/mime_types_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/theme_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/manifest_tests/chrome_manifest_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_url_handler.h View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/icon_with_badge_image_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/ini_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/ini_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/local_discovery/local_domain_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/local_discovery/service_discovery_client_impl.h View 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/common/mac/mock_launchd.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/common/multi_process_lock_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/multi_process_lock_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_posix.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/worker_thread_ticker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 08:43:14 UTC) #2
MRV
On 2014/10/06 08:43:14, MRV wrote: > PTAL Dear Mr. Sky PTAL
6 years, 2 months ago (2014-10-06 16:14:23 UTC) #3
MRV
On 2014/10/06 16:14:23, MRV wrote: > On 2014/10/06 08:43:14, MRV wrote: > > PTAL > ...
6 years, 2 months ago (2014-10-07 03:39:37 UTC) #4
sky
LGTM - but update your description, there is no final in these changes
6 years, 2 months ago (2014-10-07 15:23:28 UTC) #5
MRV
On 2014/10/07 15:23:28, sky wrote: > LGTM - but update your description, there is no ...
6 years, 2 months ago (2014-10-07 15:54:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622373003/40001
6 years, 2 months ago (2014-10-07 15:55:10 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 3c6f334ed758167fbf633cf10fe42f3468611f39
6 years, 2 months ago (2014-10-07 16:52:36 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 16:53:17 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/71dbed12744212997f7e9c6ab09d3ff3c2a4d4fc
Cr-Commit-Position: refs/heads/master@{#298506}

Powered by Google App Engine
This is Rietveld 408576698