Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: Source/bindings/templates/callback_interface.cpp

Issue 622333002: Flip the true/false result of ScriptState::contextIsValid (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY! 5 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 {% filter conditional(conditional_string) %} 8 {% filter conditional(conditional_string) %}
9 #include "{{v8_class}}.h" 9 #include "{{v8_class}}.h"
10 10
(...skipping 15 matching lines...) Expand all
26 } 26 }
27 27
28 {% for method in methods if not method.is_custom %} 28 {% for method in methods if not method.is_custom %}
29 {{method.cpp_type}} {{v8_class}}::{{method.name}}({{method.argument_declarations | join(', ')}}) 29 {{method.cpp_type}} {{v8_class}}::{{method.name}}({{method.argument_declarations | join(', ')}})
30 { 30 {
31 {% set return_default = 'return true' 31 {% set return_default = 'return true'
32 if method.idl_type == 'boolean' else 'return' %}{# void #} 32 if method.idl_type == 'boolean' else 'return' %}{# void #}
33 if (!canInvokeCallback()) 33 if (!canInvokeCallback())
34 {{return_default}}; 34 {{return_default}};
35 35
36 if (m_scriptState->contextIsValid()) 36 if (!m_scriptState->contextIsValid())
37 {{return_default}}; 37 {{return_default}};
38 38
39 ScriptState::Scope scope(m_scriptState.get()); 39 ScriptState::Scope scope(m_scriptState.get());
40 {% if method.call_with_this_handle %} 40 {% if method.call_with_this_handle %}
41 v8::Handle<v8::Value> thisHandle = thisValue.v8Value(); 41 v8::Handle<v8::Value> thisHandle = thisValue.v8Value();
42 if (thisHandle.IsEmpty()) { 42 if (thisHandle.IsEmpty()) {
43 if (!isScriptControllerTerminating()) 43 if (!isScriptControllerTerminating())
44 CRASH(); 44 CRASH();
45 {{return_default}}; 45 {{return_default}};
46 } 46 }
(...skipping 20 matching lines...) Expand all
67 ScriptController::callFunction(m_scriptState->executionContext(), m_callback .newLocal(m_scriptState->isolate()), {{this_handle_parameter}}{{method.arguments | length}}, argv, m_scriptState->isolate()); 67 ScriptController::callFunction(m_scriptState->executionContext(), m_callback .newLocal(m_scriptState->isolate()), {{this_handle_parameter}}{{method.arguments | length}}, argv, m_scriptState->isolate());
68 return !exceptionCatcher.HasCaught(); 68 return !exceptionCatcher.HasCaught();
69 {% else %}{# void #} 69 {% else %}{# void #}
70 ScriptController::callFunction(m_scriptState->executionContext(), m_callback .newLocal(m_scriptState->isolate()), {{this_handle_parameter}}{{method.arguments | length}}, argv, m_scriptState->isolate()); 70 ScriptController::callFunction(m_scriptState->executionContext(), m_callback .newLocal(m_scriptState->isolate()), {{this_handle_parameter}}{{method.arguments | length}}, argv, m_scriptState->isolate());
71 {% endif %} 71 {% endif %}
72 } 72 }
73 73
74 {% endfor %} 74 {% endfor %}
75 } // namespace blink 75 } // namespace blink
76 {% endfilter %} 76 {% endfilter %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698