Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 6223003: Add support in the ChromeFrame NPAPI plugin for receiving URL redirect notifi... (Closed)

Created:
9 years, 11 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Add support in the ChromeFrame NPAPI plugin for receiving URL redirect notifications. This is basically implementing the NPP_URLRedirectNotify plugin function and invoking the browser end function NPN_URLRedirectResponse indicating whether the redirect is to be followed or not. The ChromeFrame NPAPI implementation always disallows url redirects from the plugin and instead expects Chrome to follow the redirect. Tested this with a Firefox 4 nightly build. Currently this does not work as expected because of a bug in Firefox where it invokes the NPP_URLRedirectNotify function with the original URL instead of the redirected URL. This is tracked by mozilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=625164 BUG=69419 TEST=none. Will add a test for this once we have a builder with a working version of Firefox 4. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71271

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M chrome_frame/chrome_frame_npapi.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/chrome_frame_npapi.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome_frame/chrome_frame_npapi_entrypoints.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome_frame/chrome_frame_npapi_entrypoints.cc View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M chrome_frame/np_browser_functions.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/np_browser_functions.cc View 4 chunks +10 lines, -1 line 0 comments Download
M chrome_frame/npapi_url_request.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/npapi_url_request.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
9 years, 11 months ago (2011-01-12 21:19:47 UTC) #1
amit
lgtm http://codereview.chromium.org/6223003/diff/11001/chrome_frame/chrome_frame_npapi_entrypoints.cc File chrome_frame/chrome_frame_npapi_entrypoints.cc (right): http://codereview.chromium.org/6223003/diff/11001/chrome_frame/chrome_frame_npapi_entrypoints.cc#newcode212 chrome_frame/chrome_frame_npapi_entrypoints.cc:212: return; if we don't get a valid instance ...
9 years, 11 months ago (2011-01-12 21:50:48 UTC) #2
ananta
9 years, 11 months ago (2011-01-12 22:01:41 UTC) #3
http://codereview.chromium.org/6223003/diff/11001/chrome_frame/chrome_frame_n...
File chrome_frame/chrome_frame_npapi_entrypoints.cc (right):

http://codereview.chromium.org/6223003/diff/11001/chrome_frame/chrome_frame_n...
chrome_frame/chrome_frame_npapi_entrypoints.cc:212: return;
On 2011/01/12 21:50:48, amit wrote:
> if we don't get a valid instance then maybe we should fail the request with
> NPN_URLRedirectResponse

Done.

Powered by Google App Engine
This is Rietveld 408576698