Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: PRESUBMIT.py

Issue 62213006: Don't send try jobs to win7_aura since it's a subset of win_rel and will go away. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1018 matching lines...) Expand 10 before | Expand all | Expand 10 after
1029 1029
1030 def GetPreferredTrySlaves(project, change): 1030 def GetPreferredTrySlaves(project, change):
1031 files = change.LocalPaths() 1031 files = change.LocalPaths()
1032 1032
1033 if not files or all(re.search(r'[\\/]OWNERS$', f) for f in files): 1033 if not files or all(re.search(r'[\\/]OWNERS$', f) for f in files):
1034 return [] 1034 return []
1035 1035
1036 if all(re.search('\.(m|mm)$|(^|[/_])mac[/_.]', f) for f in files): 1036 if all(re.search('\.(m|mm)$|(^|[/_])mac[/_.]', f) for f in files):
1037 return ['mac_rel', 'mac:compile'] 1037 return ['mac_rel', 'mac:compile']
1038 if all(re.search('(^|[/_])win[/_.]', f) for f in files): 1038 if all(re.search('(^|[/_])win[/_.]', f) for f in files):
1039 return ['win_rel', 'win7_aura', 'win:compile'] 1039 return ['win_rel', 'win:compile']
1040 if all(re.search('(^|[/_])android[/_.]', f) for f in files): 1040 if all(re.search('(^|[/_])android[/_.]', f) for f in files):
1041 return ['android_aosp', 'android_dbg', 'android_clang_dbg'] 1041 return ['android_aosp', 'android_dbg', 'android_clang_dbg']
1042 if all(re.search('^native_client_sdk', f) for f in files): 1042 if all(re.search('^native_client_sdk', f) for f in files):
1043 return ['linux_nacl_sdk', 'win_nacl_sdk', 'mac_nacl_sdk'] 1043 return ['linux_nacl_sdk', 'win_nacl_sdk', 'mac_nacl_sdk']
1044 if all(re.search('[/_]ios[/_.]', f) for f in files): 1044 if all(re.search('[/_]ios[/_.]', f) for f in files):
1045 return ['ios_rel_device', 'ios_dbg_simulator'] 1045 return ['ios_rel_device', 'ios_dbg_simulator']
1046 1046
1047 trybots = [ 1047 trybots = [
1048 'android_clang_dbg', 1048 'android_clang_dbg',
1049 'android_dbg', 1049 'android_dbg',
1050 'ios_dbg_simulator', 1050 'ios_dbg_simulator',
1051 'ios_rel_device', 1051 'ios_rel_device',
1052 'linux_asan', 1052 'linux_asan',
1053 'linux_aura', 1053 'linux_aura',
1054 'linux_chromeos', 1054 'linux_chromeos',
1055 'linux_clang:compile', 1055 'linux_clang:compile',
1056 'linux_rel', 1056 'linux_rel',
1057 'mac_rel', 1057 'mac_rel',
1058 'mac:compile', 1058 'mac:compile',
1059 'win7_aura',
1060 'win_rel', 1059 'win_rel',
1061 'win:compile', 1060 'win:compile',
1062 'win_x64_rel:base_unittests', 1061 'win_x64_rel:base_unittests',
1063 ] 1062 ]
1064 1063
1065 # Match things like path/aura/file.cc and path/file_aura.cc. 1064 # Match things like path/aura/file.cc and path/file_aura.cc.
1066 # Same for chromeos. 1065 # Same for chromeos.
1067 if any(re.search('[/_](aura|chromeos)', f) for f in files): 1066 if any(re.search('[/_](aura|chromeos)', f) for f in files):
1068 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan'] 1067 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan']
1069 1068
1070 # If there are gyp changes to base, build, or chromeos, run a full cros build 1069 # If there are gyp changes to base, build, or chromeos, run a full cros build
1071 # in addition to the shorter linux_chromeos build. Changes to high level gyp 1070 # in addition to the shorter linux_chromeos build. Changes to high level gyp
1072 # files have a much higher chance of breaking the cros build, which is 1071 # files have a much higher chance of breaking the cros build, which is
1073 # differnt from the linux_chromeos build that most chrome developers test 1072 # differnt from the linux_chromeos build that most chrome developers test
1074 # with. 1073 # with.
1075 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files): 1074 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files):
1076 trybots += ['cros_x86'] 1075 trybots += ['cros_x86']
1077 1076
1078 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1077 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1079 # unless they're .gyp(i) files as changes to those files can break the gyp 1078 # unless they're .gyp(i) files as changes to those files can break the gyp
1080 # step on that bot. 1079 # step on that bot.
1081 if (not all(re.search('^chrome', f) for f in files) or 1080 if (not all(re.search('^chrome', f) for f in files) or
1082 any(re.search('\.gypi?$', f) for f in files)): 1081 any(re.search('\.gypi?$', f) for f in files)):
1083 trybots += ['android_aosp'] 1082 trybots += ['android_aosp']
1084 1083
1085 return trybots 1084 return trybots
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698