runtime/vm/flow_graph_compiler_mips.cc - Issue 62203018: Remove dead code from IfThenElse and StrictCompare in the compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 62203018: Remove dead code from IfThenElse and StrictCompare in the compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_mips.cc

===================================================================

--- runtime/vm/flow_graph_compiler_mips.cc (revision 30390)

+++ runtime/vm/flow_graph_compiler_mips.cc (working copy)

@@ -1485,8 +1485,8 @@

bool needs_number_check,

intptr_t token_pos) {

__ TraceSimMsg("EqualityRegConstCompare");

- if (needs_number_check &&

- (obj.IsMint() || obj.IsDouble() || obj.IsBigint())) {

+ if (needs_number_check) {

+ ASSERT(!obj.IsMint() && !obj.IsDouble() && !obj.IsBigint());

__ addiu(SP, SP, Immediate(-2 * kWordSize));

__ sw(reg, Address(SP, 1 * kWordSize));

__ LoadObject(TMP, obj);

« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »