Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2192)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 62203007: Implement memory-persistent registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address kinuko's comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index 696c5c1867bd8ee95b9c45ce2c8b0ff3e4cf97d0..b6614fa4c9700e98906164f7230de4b4ff2ff266 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -83,7 +83,7 @@ bool ServiceWorkerDispatcherHost::OnMessageReceived(
void ServiceWorkerDispatcherHost::OnRegisterServiceWorker(
int32 thread_id,
int32 request_id,
- const GURL& scope,
+ const GURL& pattern,
const GURL& script_url) {
if (!context_ || !context_->IsEnabled()) {
Send(new ServiceWorkerMsg_ServiceWorkerRegistrationError(
@@ -97,7 +97,7 @@ void ServiceWorkerDispatcherHost::OnRegisterServiceWorker(
// TODO(alecflett): This check is insufficient for release. Add a
// ServiceWorker-specific policy query in
// ChildProcessSecurityImpl. See http://crbug.com/311631.
- if (scope.GetOrigin() != script_url.GetOrigin()) {
+ if (pattern.GetOrigin() != script_url.GetOrigin()) {
Send(new ServiceWorkerMsg_ServiceWorkerRegistrationError(
thread_id,
request_id,
@@ -110,9 +110,10 @@ void ServiceWorkerDispatcherHost::OnRegisterServiceWorker(
thread_id, request_id, NextWorkerId()));
}
-void ServiceWorkerDispatcherHost::OnUnregisterServiceWorker(int32 thread_id,
- int32 request_id,
- const GURL& scope) {
+void ServiceWorkerDispatcherHost::OnUnregisterServiceWorker(
+ int32 thread_id,
+ int32 request_id,
+ const GURL& pattern) {
// TODO(alecflett): This check is insufficient for release. Add a
// ServiceWorker-specific policy query in
// ChildProcessSecurityImpl. See http://crbug.com/311631.

Powered by Google App Engine
This is Rietveld 408576698