Issue 6220001: Add GC throughput metrics to gc-nvp-trace-processor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6220001: Add GC throughput metrics to gc-nvp-trace-processor. (Closed)

Created:
9 years, 11 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Add GC throughput metrics to gc-nvp-trace-processor. Committed: http://code.google.com/p/v8/source/detail?r=6246

Patch Set 1 #

Total comments: 3

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -2 lines)			Patch
	M	tools/gc-nvp-trace-processor.py	View		5 chunks	+32 lines, -2 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 11 months ago (2011-01-10 12:21:07 UTC) #2

lgtm

http://codereview.chromium.org/6220001/diff/1/tools/gc-nvp-trace-processor.py
File tools/gc-nvp-trace-processor.py (right):

http://codereview.chromium.org/6220001/diff/1/tools/gc-nvp-trace-processor.py...
tools/gc-nvp-trace-processor.py:307: suffixes = ['B', 'KB', 'MB', 'GB']
K -> k
I also prefer bytes to B since B is a measure of volume but that may look messy
in the output?

http://codereview.chromium.org/6220001/diff/1/tools/gc-nvp-trace-processor.py...
tools/gc-nvp-trace-processor.py:322: HumanReadable(total_live_after /
total_gc)))
Should we check for total_gc being zero?

http://codereview.chromium.org/6220001/diff/1/tools/gc-nvp-trace-processor.py...
tools/gc-nvp-trace-processor.py:344: throughput('MS', marksweeps)
This seems excessively concise.

Expand Messages | Collapse Messages