Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 621983002: Roll usrsctp 8912:9029 (Closed)

Created:
6 years, 2 months ago by Sergey Ulanov
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@branch_2125
Project:
chromium
Visibility:
Public.

Description

Roll usrsctp 8912:9029 The roll contains changes necessary to compile usrsctp for NaCl. BUG=402993 TBR=lally@chromium.com Committed: https://crrev.com/e8623a0457cdea95a74220fd683f2f613f830281 Cr-Commit-Position: refs/heads/master@{#297745}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/usrsctp/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
Sergey Ulanov
6 years, 2 months ago (2014-10-01 21:58:57 UTC) #2
Mallinath (Gone from Chromium)
On 2014/10/01 21:58:57, Sergey Ulanov wrote: lgtm Added Lally who is the main owner and ...
6 years, 2 months ago (2014-10-01 22:01:31 UTC) #4
Mallinath (Gone from Chromium)
On 2014/10/01 22:01:31, mallinath2 wrote: > On 2014/10/01 21:58:57, Sergey Ulanov wrote: > > lgtm ...
6 years, 2 months ago (2014-10-01 22:04:11 UTC) #5
Sergey Ulanov
On 2014/10/01 22:04:11, mallinath2 wrote: > On 2014/10/01 22:01:31, mallinath2 wrote: > > On 2014/10/01 ...
6 years, 2 months ago (2014-10-01 22:44:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621983002/20001
6 years, 2 months ago (2014-10-01 22:47:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/73847) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/63254) win_gpu ...
6 years, 2 months ago (2014-10-01 22:51:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621983002/40001
6 years, 2 months ago (2014-10-01 23:06:30 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14844)
6 years, 2 months ago (2014-10-01 23:16:26 UTC) #14
Sergey Ulanov
+lally@chromium.com in TBR (looks like Mallinath is not an owner anymore)
6 years, 2 months ago (2014-10-01 23:31:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621983002/40001
6 years, 2 months ago (2014-10-01 23:34:17 UTC) #17
chromium-reviews
Yea, I removed it last week. Since you are a full committer I though that ...
6 years, 2 months ago (2014-10-01 23:34:41 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 1c00c1a15f366113d7335182271a81a770e0bb16
6 years, 2 months ago (2014-10-02 00:12:20 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 00:12:56 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e8623a0457cdea95a74220fd683f2f613f830281
Cr-Commit-Position: refs/heads/master@{#297745}

Powered by Google App Engine
This is Rietveld 408576698