Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 621963002: Reland the initial attempt to start building ui_base_unittests targets. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
M-A Ruel, sky
CC:
chromium-reviews, kalyank, klundberg+watch_chromium.org, sadrul, yfriedman+watch_chromium.org, ben+ash_chromium.org, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland the inital attempt to start building ui_base_unittests targets. Inital commit: https://crrev.com/430fc906824927713d5a318afb50654e95b699b0 The first attempt was reverted because there was no ui_base_unittests_disabled file to disable the test on Android like there was for ui_unittests. Reverted by: https://crrev.com/79c886b2fa50d0634d8d8a84903f9a9ea96f5471 The fix for the revert was made by commit at https://crrev.com/4642d9377d3044c81d0f32298ba0c203976c8cc9 BUG=331829, 373148, 299841, 103304 TEST=None R=sky@chromium.org,maruel@chromium.org Committed: https://crrev.com/201471d5acade51f594b703a3ae6307d566a3966 Cr-Commit-Position: refs/heads/master@{#297865}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M build/all.gyp View 10 chunks +10 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tfarina
PTAL.
6 years, 2 months ago (2014-10-02 02:28:36 UTC) #1
M-A Ruel
mostly rubberstamp lgtm https://codereview.chromium.org/621963002/diff/1/ash/wm/ash_native_cursor_manager_unittest.cc File ash/wm/ash_native_cursor_manager_unittest.cc (right): https://codereview.chromium.org/621963002/diff/1/ash/wm/ash_native_cursor_manager_unittest.cc#newcode187 ash/wm/ash_native_cursor_manager_unittest.cc:187: // This test is in ash_unittests ...
6 years, 2 months ago (2014-10-02 13:22:12 UTC) #2
tfarina
https://codereview.chromium.org/621963002/diff/1/ash/wm/ash_native_cursor_manager_unittest.cc File ash/wm/ash_native_cursor_manager_unittest.cc (right): https://codereview.chromium.org/621963002/diff/1/ash/wm/ash_native_cursor_manager_unittest.cc#newcode187 ash/wm/ash_native_cursor_manager_unittest.cc:187: // This test is in ash_unittests becuase ui_base_unittests does ...
6 years, 2 months ago (2014-10-02 13:59:45 UTC) #3
sky
LGTM
6 years, 2 months ago (2014-10-02 17:18:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621963002/20001
6 years, 2 months ago (2014-10-02 17:39:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as bf3307c717f231825500b179d12fde2d591c106d
6 years, 2 months ago (2014-10-02 18:12:21 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 18:12:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/201471d5acade51f594b703a3ae6307d566a3966
Cr-Commit-Position: refs/heads/master@{#297865}

Powered by Google App Engine
This is Rietveld 408576698