Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 621953002: Anchor ChromeShell's suggestion popup to the entire toolbar. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Anchor ChromeShell's suggestion popup to the entire toolbar. BUG=419407 Committed: https://crrev.com/b433dd56f26262e6d20146c95b9e072c37c674a0 Cr-Commit-Position: refs/heads/master@{#297744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
aurimas (slooooooooow)
PTAL
6 years, 2 months ago (2014-10-01 18:24:20 UTC) #2
jdduke (slow)
Noice! lgtm though I'm not an owner.
6 years, 2 months ago (2014-10-01 18:38:23 UTC) #3
aurimas (slooooooooow)
dtrainor: for OWNERS review.
6 years, 2 months ago (2014-10-01 18:40:06 UTC) #5
David Trainor- moved to gerrit
lgtm
6 years, 2 months ago (2014-10-01 23:14:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621953002/1
6 years, 2 months ago (2014-10-01 23:38:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5dd939d8f08f8197e954a8c711b2ac610096be1b
6 years, 2 months ago (2014-10-02 00:02:52 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 00:04:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b433dd56f26262e6d20146c95b9e072c37c674a0
Cr-Commit-Position: refs/heads/master@{#297744}

Powered by Google App Engine
This is Rietveld 408576698