Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 62193004: XHR: separate delayed progress event flushing from dispatching of new. (Closed)

Created:
7 years, 1 month ago by sof
Modified:
7 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

XHR: separate delayed progress event flushing from dispatching of new. The throttled delivery of progress events may defer progress event delivery so as to pace their dispatching down to the frequency that the spec suggests. When dispatching a later 'readystatechange' event, if no deferred progress event was present, a new one would be created and dispatched. Achieving the same event sequence despite the lazy/deferred delivery of 'progress' events. There are two steps involved here: the potential expedition of the deferred progress event and the creation & delivery of a new one. Tease these two notions apart here by allowing only flushing of a deferred progress event to happen. This weaker form of flushing is needed by follow-on changes, which alters how these 'progress' progress events are dispatched wrt the 'readystatechange' XHR event when handling request errors and aborts. R= BUG=315488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M Source/core/xml/XMLHttpRequestProgressEventThrottle.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequestProgressEventThrottle.cpp View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
At your leisure, please take a look. (Split out from crrev.com/61793010)
7 years, 1 month ago (2013-11-18 22:27:50 UTC) #1
sof
7 years, 1 month ago (2013-11-18 22:28:44 UTC) #2
abarth-chromium
lgtm
7 years, 1 month ago (2013-11-18 23:14:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/62193004/1
7 years, 1 month ago (2013-11-18 23:14:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/62193004/1
7 years, 1 month ago (2013-11-19 06:34:49 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 08:02:39 UTC) #6
Message was sent while issue was closed.
Change committed as 162270

Powered by Google App Engine
This is Rietveld 408576698