Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 62193003: Remove deprecated v8::SetResourceConstraints without Isolate parameter (Closed)

Created:
7 years, 1 month ago by rmcilroy
Modified:
7 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove deprecated v8::SetResourceConstraints without Isolate parameter LOG=Y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17910

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M include/v8.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M test/cctest/test-api.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-strings.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Benedikt, please take a look.
7 years, 1 month ago (2013-11-18 20:59:37 UTC) #1
Benedikt Meurer
Thanks Ross. LGTM.
7 years, 1 month ago (2013-11-19 06:31:59 UTC) #2
rmcilroy
7 years, 1 month ago (2013-11-20 11:22:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r17910 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698