Integrate UI and reset logic into AutomaticProfileResetter.

chrome/browser/profile_resetter/automatic_profile_resetter.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_H_
 #define CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 18 matching lines @@
 // triggering the prompt. To ensure that the prompt only appears at most once
 // for any given profile, a "memento" that the prompt has appeared is written to
 // the profile on disk; see automatic_profile_resetter_mementos.h for details.
 // The service is created automatically with the Profile and is activated right
 // away by its factory. To avoid delaying start-up, however, it will only start
 // working after a short delay.
 // All methods in this class shall be called on the UI thread, except when noted
 // otherwise.
 class AutomaticProfileResetter : public BrowserContextKeyedService {
  public:
+  // Enumeration of the possible outcomes of showing the profile reset prompt.
+  enum PromptResult {
+    // Prompt was not shown because only a dry-run was performed, or because it
+    // was not supported on the current platform.
+    PROMPT_NOT_SHOWN,
+    PROMPT_ACTION_RESET,
+    PROMPT_ACTION_NO_RESET,
+    // The prompt was shown, but the user dismissed the reset bubble without
+    // taking definitive action (selecting either "Reset" or "No, thanks").
+    // Note: deprecated in favor of the following three items.
+    PROMPT_DISMISSED,
+    // The reset bubble was still shown; or dismissed without taking definitive
+    // action when Chrome was closed.
+    PROMPT_IGNORED,
+    // The reset bubble was shown, then dismissed without taking definitive
+    // action. Then, however, the user initiated or refrained from (resp.) doing
+    // a reset from the conventional, WebUI-based reset dialog.
+    PROMPT_FOLLOWED_BY_WEBUI_RESET,
+    PROMPT_FOLLOWED_BY_WEBUI_NO_RESET,
+    // The reset bubble was suppressed (not shown) because another bubble was
+    // already being shown at the time. Regardless, however, the user initiated

[MAD, 2013/11/11 16:38:32]

Is another bubble (will always be) the only reason to not show the reset bubble?
If not, we should add e.g., (or for example).

[engedy, 2013/11/13 00:40:44]

For the foreseeable future, yes. Regarding later, I would prefer not adding
uncertainty to comments, and trusting that whomever will modify this invariant
will update this as well.

+    // or refrained from (resp.) doing a reset from the conventional, WebUI-
+    // based reset dialog.
+    PROMPT_SUPPRESSED_BUT_HAD_WEBUI_RESET,
+    PROMPT_SUPPRESSED_BUT_HAD_WEBUI_NO_RESET,
+    PROMPT_RESULT_MAX
+  };
+
   explicit AutomaticProfileResetter(Profile* profile);
   virtual ~AutomaticProfileResetter();
 
   // Initializes the service if it is enabled in the field trial. Otherwise,
   // skips the initialization steps, and also permanently disables the service.
   // Called by AutomaticProfileResetterFactory.
   void Initialize();
 
   // Fires up the service by unleashing the asynchronous evaluation flow, unless
   // the service has been already disabled in Initialize() or there is no
   // |program_| to run (in which case the service also gets disabled).
   // Called by the AutomaticProfileResetterFactory.
   void Activate();
 
+  // Called synchronously by ProfileResetGlobalError in case the user chooses to
+  // reset their profile settings from inside the reset bubble. Will trigger the
+  // reset, optionally |send_feedback|, and conclude the reset prompt flow.
+  void TriggerProfileReset(bool send_feedback);
+
+  // Called synchronously by ProfileResetGlobalError in case the user chooses
+  // from inside the reset bubble that they do not want to reset their profile
+  // settings. Will conclude the reset prompt flow without setting off a reset.
+  void SkipProfileReset();
+
+  // Returns whether or not the profile reset prompt flow is currently active.
+  // See BeginResetPromptFlow() for a description of what this means.
+  bool IsResetPromptActive() const;
+
+  // Called synchronously by ProfileResetGlobalError to give notice that the
+  // reset bubble has actually been shown.
+  void NotifyDidShowResetBubble();
+
+  // Called by ResetProfileSettingsHandler to give notice that the conventional,
+  // WebUI-based settings reset dialog has been opened. This will already
+  // dismiss the menu item in the wrench menu. This should be always followed by
+  // a corresponding NotifyDidCloseWebUIResetDialog() call.
+  void NotifyDidOpenWebUIResetDialog();
+
+  // Called by ResetProfileSettingsHandler to give notice that the conventional,
+  // WebUI-based settings reset dialog has been closed, with |performed_reset|
+  // indicating whether or not a reset was requested. This is required so that
+  // we can record the appropriate PromptResult, and conclude the reset prompt
+  // flow early without setting off any more resets in the future.
+  void NotifyDidCloseWebUIResetDialog(bool performed_reset);
+
+  base::WeakPtr<AutomaticProfileResetter> AsWeakPtr() {
+    return weak_ptr_factory_.GetWeakPtr();
+  }
+
+  // BrowserContextKeyedService:
+  virtual void Shutdown() OVERRIDE;
+
   // Should be called before Activate().
   void SetProgramForTesting(const std::string& program);
 
   // Should be called before Activate().
   void SetHashSeedForTesting(const std::string& hash_seed);
 
   // Should be called before Activate().
   void SetDelegateForTesting(
       scoped_ptr<AutomaticProfileResetterDelegate> delegate);
 
   // Should be called before Activate(). Sets the task runner to be used to post
   // task |PrepareEvaluationFlow| in a delayed manner.
   void SetTaskRunnerForWaitingForTesting(
       const scoped_refptr<base::TaskRunner>& task_runner);
 
  private:
   struct EvaluationResults;
 
   enum State {
     STATE_UNINITIALIZED,
     STATE_INITIALIZED,
     STATE_DISABLED,
     STATE_WAITING_ON_DEPENDENCIES,
     STATE_READY,
-    STATE_WORKING,
+    STATE_EVALUATING_CONDITIONS,
+    // The reset prompt can always be active in the next two states.
+    // can only possible received (synchronous) call-backs from it here.

[MAD, 2013/11/11 16:38:32]

"can only possible received"?

please rephrase... 

[engedy, 2013/11/13 00:40:44]

Reworked this part.

+    STATE_AWAITING_USER_CHOICE,
+    STATE_PERFORMING_RESET,
     STATE_DONE
   };
 
   // Prepares the asynchronous evaluation flow by requesting services that it
   // depends on to make themselves ready.
   void PrepareEvaluationFlow();
 
   // Called back by |resetter_delegate_| when the template URL service is ready.
   void OnTemplateURLServiceIsLoaded();
 
@@ skipping 24 matching lines @@
   // |program| that will evaluate whether the conditions are met for showing the
   // reset prompt. The program will make this decision based on the state
   // information contained in |input| in the form of key-value pairs. The
   // program will only see hashed keys and values that are produced using
   // |hash_seed| as a key.
   static scoped_ptr<EvaluationResults> EvaluateConditionsOnWorkerPoolThread(
       const std::string& hash_seed,
       const std::string& program,
       scoped_ptr<base::DictionaryValue> program_input);
 
-  // Called back when EvaluateConditionsOnWorkerPoolThread completes executing
-  // the program with |results|. Finishes the evaluation flow, and, based on the
-  // result, will potentially show the reset prompt.
-  void FinishEvaluationFlow(scoped_ptr<EvaluationResults> results);
-
   // Reports the given metrics through UMA. Virtual, so it can be mocked out in
   // tests to verify that the correct value are being reported.
   virtual void ReportStatistics(uint32 satisfied_criteria_mask,
                                 uint32 combined_status_mask);
 
-  // BrowserContextKeyedService:
-  virtual void Shutdown() OVERRIDE;
+  // Called back when EvaluateConditionsOnWorkerPoolThread completes executing
+  // the program with |results|. Finishes the evaluation flow, and, based on the
+  // result, potentially initiates the reset prompt flow.
+  void FinishEvaluationFlow(scoped_ptr<EvaluationResults> results);
+
+  // Begins the reset prompt flow by triggering the reset prompt, which consists
+  // of two parts: (1.) the profile reset (pop-up) bubble, and (2.) a menu item
+  // in the wrench menu.
+  // The flow is considered to be "active" until we receive a clear indication
+  // from the user about whether or not they wish to reset their settings. This
+  // indication can come in a variety of flavors:
+  //  * taking definitive action (i.e. selecting either "Reset" or "No, thanks")
+  //    in the pop-up reset bubble itself,
+  //  * dismissing the bubble, but then selecting the wrench menu item, which
+  //    takes them to the WebUI reset dialog in chrome://settings, and then
+  //    making their choice there,
+  //  * going to the WebUI reset dialog by themselves.
+  void BeginResetPromptFlow();
+
+  // Called back by the ProfileResetter once resetting the profile settings has
+  // been completed, when requested by the user from inside the reset bubble.
+  // Will conclude the reset prompt flow.
+  void OnProfileSettingsResetCompleted();
+
+  // Reports the result of showing the prompt through UMA. Virtual, so it can be
+  // mocked out in tests to verify that the correct value is being reported.
+  virtual void ReportPromptResult(PromptResult result);
+
+  // Dismisses the reset prompt and concludes the reset prompt flow with
+  // |prompt_result|, then persists the memento values returned by the evaluator
+  // program to disk.
+  void FinishResetPromptFlow(PromptResult prompt_result);
 
   Profile* profile_;
 
   State state_;
   bool enumeration_of_loaded_modules_ready_;
   bool template_url_service_ready_;
+  bool has_shown_bubble_;
 
   std::string hash_seed_;
   std::string program_;
 
+  scoped_ptr<EvaluationResults> evaluation_results_;
+
   PreferenceHostedPromptMemento memento_in_prefs_;
   LocalStateHostedPromptMemento memento_in_local_state_;
   FileHostedPromptMemento memento_in_file_;
 
   scoped_ptr<AutomaticProfileResetterDelegate> delegate_;
   scoped_refptr<base::TaskRunner> task_runner_for_waiting_;
 
   base::WeakPtrFactory<AutomaticProfileResetter> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutomaticProfileResetter);
 };
 
 #endif  // CHROME_BROWSER_PROFILE_RESETTER_AUTOMATIC_PROFILE_RESETTER_H_