Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 621903004: Adds View::visible() and IsDrawn (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds View::visible() and IsDrawn State is now properly mirrored from server. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/6b4a43ff296991792030b37d25f0bb5a401d012a Cr-Commit-Position: refs/heads/master@{#297716}

Patch Set 1 #

Patch Set 2 : git cl format #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -24 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view.cc View 1 4 chunks +35 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 2 4 chunks +16 lines, -14 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_private.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 2 1 chunk +111 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_unittest.cc View 1 7 chunks +80 lines, -5 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view.h View 1 2 3 chunks +15 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_observer.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
6 years, 2 months ago (2014-10-01 20:36:11 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 2 months ago (2014-10-01 20:47:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621903004/40001
6 years, 2 months ago (2014-10-01 21:06:19 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 3c4fbfb6b3cf92ce3d14301c8b9943c485892dd9
6 years, 2 months ago (2014-10-01 21:52:26 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 21:52:48 UTC) #6
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6b4a43ff296991792030b37d25f0bb5a401d012a
Cr-Commit-Position: refs/heads/master@{#297716}

Powered by Google App Engine
This is Rietveld 408576698