Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 621903003: Add MediaKeySession.expiration attribute. (Closed)

Created:
6 years, 2 months ago by jrummell
Modified:
6 years, 2 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, philipj_slow, eric.carlson_apple.com, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add MediaKeySession.expiration attribute. BUG=358271 TEST=existing EME tests still pass + private tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183708

Patch Set 1 #

Total comments: 4

Patch Set 2 : const #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/modules/encryptedmedia/MediaKeySession.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 2 4 chunks +5 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jrummell
PTAL.
6 years, 2 months ago (2014-10-01 20:31:12 UTC) #2
sandersd (OOO until July 31)
lgtm https://codereview.chromium.org/621903003/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp File Source/modules/encryptedmedia/MediaKeySession.cpp (right): https://codereview.chromium.org/621903003/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp#newcode53 Source/modules/encryptedmedia/MediaKeySession.cpp:53: #include <limits> These should be between the two ...
6 years, 2 months ago (2014-10-01 22:57:52 UTC) #3
ddorwin
https://codereview.chromium.org/621903003/diff/1/Source/modules/encryptedmedia/MediaKeySession.h File Source/modules/encryptedmedia/MediaKeySession.h (right): https://codereview.chromium.org/621903003/diff/1/Source/modules/encryptedmedia/MediaKeySession.h#newcode73 Source/modules/encryptedmedia/MediaKeySession.h:73: double expiration() { return m_expiration; } const function
6 years, 2 months ago (2014-10-01 23:00:53 UTC) #4
jrummell
Updated. https://codereview.chromium.org/621903003/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp File Source/modules/encryptedmedia/MediaKeySession.cpp (right): https://codereview.chromium.org/621903003/diff/1/Source/modules/encryptedmedia/MediaKeySession.cpp#newcode53 Source/modules/encryptedmedia/MediaKeySession.cpp:53: #include <limits> On 2014/10/01 22:57:52, sandersd wrote: > ...
6 years, 2 months ago (2014-10-03 00:36:10 UTC) #5
ddorwin
lgtm
6 years, 2 months ago (2014-10-03 03:35:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621903003/50001
6 years, 2 months ago (2014-10-14 22:07:58 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 00:31:05 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:50001) as 183708

Powered by Google App Engine
This is Rietveld 408576698