Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 621863002: [turbofan] Fix lowering of typed loads/stores. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix lowering of typed loads/stores. We can only access to external typed arrays; lowering of internal typed arrays would require a map check plus eager deoptimization. Also embed the array buffer reference directly instead of embedding the typed array. TEST=cctest,mjsunit,unittests R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24386

Patch Set 1 #

Patch Set 2 : Refactoring #

Patch Set 3 : Fixes #

Patch Set 4 : Fixes2 #

Total comments: 1

Patch Set 5 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -68 lines) Patch
M src/compiler/access-builder.cc View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 2 chunks +48 lines, -50 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M src/factory.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 3 4 3 chunks +40 lines, -2 lines 0 comments Download
M src/handles.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/graph-unittest.h View 1 3 chunks +25 lines, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 5 chunks +215 lines, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
A test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 1 chunk +151 lines, -0 lines 0 comments Download
M test/unittests/test-utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/test-utils.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-01 14:18:58 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/621863002/diff/60001/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/621863002/diff/60001/src/factory.cc#newcode1773 src/factory.cc:1773: array->set_length(*NewNumberFromSize(length)); This is not handle-safe I think, GCMole ...
6 years, 2 months ago (2014-10-02 08:33:07 UTC) #2
Benedikt Meurer
6 years, 2 months ago (2014-10-02 08:38:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 24386 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698