Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 621833003: Implement inlined stack-check guards in TurboFan. (Closed)

Created:
6 years, 2 months ago by Michael Starzinger
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Implement inlined stack-check guards in TurboFan. R=bmeurer@chromium.org TEST=cctest/test-run-stackcheck/TerminateAtMethodEntry Committed: https://code.google.com/p/v8/source/detail?r=24367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -7 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +20 lines, -2 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/compiler/test-run-stackcheck.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 2 months ago (2014-10-01 13:26:42 UTC) #1
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-01 13:32:27 UTC) #2
Michael Starzinger
6 years, 2 months ago (2014-10-01 14:03:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698