Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 621833002: Extract runtime functions for classes into a separate file. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Extract runtime functions for classes into a separate file. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24364

Patch Set 1 #

Total comments: 1

Patch Set 2 : Includes cleaned up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -91 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.cc View 1 chunk +0 lines, -91 lines 0 comments Download
A src/runtime/runtime-classes.cc View 1 1 chunk +109 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 2 months ago (2014-10-01 11:33:31 UTC) #1
Yang
On 2014/10/01 11:33:31, Dmitry Lomov (chromium) wrote: > PTAL lgtm if comment is addressed.
6 years, 2 months ago (2014-10-01 11:39:56 UTC) #2
Yang
https://codereview.chromium.org/621833002/diff/1/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/621833002/diff/1/src/runtime/runtime-classes.cc#newcode23 src/runtime/runtime-classes.cc:23: #include "src/utils.h" Can we do an audit of those ...
6 years, 2 months ago (2014-10-01 11:40:29 UTC) #3
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-01 12:11:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) manually as 24364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698