Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/ui/app_list/search/webstore/webstore_result.cc

Issue 621823004: Simplifies the structure of app_list search a bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/webstore/webstore_result.cc
diff --git a/chrome/browser/ui/app_list/search/webstore/webstore_result.cc b/chrome/browser/ui/app_list/search/webstore/webstore_result.cc
index 6b3d25b9e13d919a1cfa0c513ee2d6c66332dc9c..cf7e31e6546c13d44c4ed1e85e432a56ce276dd1 100644
--- a/chrome/browser/ui/app_list/search/webstore/webstore_result.cc
+++ b/chrome/browser/ui/app_list/search/webstore/webstore_result.cc
@@ -16,6 +16,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
#include "chrome/browser/ui/app_list/search/common/url_icon_source.h"
+#include "chrome/browser/ui/app_list/search/search_util.h"
#include "chrome/browser/ui/app_list/search/webstore/webstore_installer.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/extensions/application_launch.h"
@@ -105,6 +106,7 @@ WebstoreResult::~WebstoreResult() {
}
void WebstoreResult::Open(int event_flags) {
+ RecordHistogram(SEARCH_WEBSTORE_SEARCH_RESULT);
const GURL store_url = net::AppendQueryParameter(
GURL(extension_urls::GetWebstoreItemDetailURLPrefix() + app_id_),
extension_urls::kWebstoreSourceField,
@@ -128,14 +130,14 @@ void WebstoreResult::InvokeAction(int action_index, int event_flags) {
StartInstall(action_index == kLaunchEphemeralAppAction);
}
-scoped_ptr<ChromeSearchResult> WebstoreResult::Duplicate() {
- return scoped_ptr<ChromeSearchResult>(new WebstoreResult(profile_,
- app_id_,
- localized_name_,
- icon_url_,
- is_paid_,
- item_type_,
- controller_)).Pass();
+scoped_ptr<SearchResult> WebstoreResult::Duplicate() {
+ return scoped_ptr<SearchResult>(new WebstoreResult(profile_,
+ app_id_,
+ localized_name_,
+ icon_url_,
+ is_paid_,
+ item_type_,
+ controller_));
}
void WebstoreResult::InitAndStartObserving() {
@@ -301,8 +303,4 @@ void WebstoreResult::OnShutdown(extensions::ExtensionRegistry* registry) {
StopObservingRegistry();
}
-ChromeSearchResultType WebstoreResult::GetType() {
- return SEARCH_WEBSTORE_SEARCH_RESULT;
-}
-
} // namespace app_list

Powered by Google App Engine
This is Rietveld 408576698