Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/ui/app_list/search/search_util.h

Issue 621823004: Simplifies the structure of app_list search a bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/search_util.h
diff --git a/chrome/browser/ui/app_list/search/search_util.h b/chrome/browser/ui/app_list/search/search_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..e920c808dd7ffe7a1a369f9cff55de838e05dbba
--- /dev/null
+++ b/chrome/browser/ui/app_list/search/search_util.h
@@ -0,0 +1,31 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
tapted 2014/10/03 02:59:17 nit: no (c)
Jun Mukai 2014/10/03 20:23:36 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_APP_LIST_SEARCH_SEARCH_UTIL_H_
+#define CHROME_BROWSER_UI_APP_LIST_SEARCH_SEARCH_UTIL_H_
+
+namespace app_list {
+
+// The type of the chrome search result. This is used for logging so do not
+// change the order of this enum.
+enum SearchResultType {
+ // A result that forwards an omnibox search result.
+ OMNIBOX_SEARCH_RESULT,
+ // An app result.
+ APP_SEARCH_RESULT,
+ // A search result from the webstore.
+ WEBSTORE_SEARCH_RESULT,
+ // A result that opens a webstore search.
+ SEARCH_WEBSTORE_SEARCH_RESULT,
+ // A result that opens a people search.
+ SEARCH_PEOPLE_SEARCH_RESULT,
+ SEARCH_RESULT_TYPE_BOUNDARY
+};
+
+// Record a UMA histogram.
+void RecordHistogram(SearchResultType type);
+
+} // namespace app_list
+
+#endif // CHROME_BROWSER_UI_APP_LIST_SEARCH_SEARCH_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698