Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/ui/app_list/search/search_webstore_result.cc

Issue 621823004: Simplifies the structure of app_list search a bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/search_webstore_result.cc
diff --git a/chrome/browser/ui/app_list/search/search_webstore_result.cc b/chrome/browser/ui/app_list/search/search_webstore_result.cc
index fa5f1b57fdb75ca7d1d8841acd0d9f38efadc75e..03a1766f2fe4b66100f2e6ef481e8892496981eb 100644
--- a/chrome/browser/ui/app_list/search/search_webstore_result.cc
+++ b/chrome/browser/ui/app_list/search/search_webstore_result.cc
@@ -6,6 +6,7 @@
#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/ui/app_list/search/search_util.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/grit/generated_resources.h"
@@ -42,6 +43,7 @@ SearchWebstoreResult::SearchWebstoreResult(Profile* profile,
SearchWebstoreResult::~SearchWebstoreResult() {}
void SearchWebstoreResult::Open(int event_flags) {
+ RecordHistogram(WEBSTORE_SEARCH_RESULT);
const GURL store_url = net::AppendQueryParameter(
launch_url_,
extension_urls::kWebstoreSourceField,
@@ -54,16 +56,8 @@ void SearchWebstoreResult::Open(int event_flags) {
chrome::Navigate(&params);
}
-void SearchWebstoreResult::InvokeAction(int action_index, int event_flags) {
-}
-
-scoped_ptr<ChromeSearchResult> SearchWebstoreResult::Duplicate() {
- return scoped_ptr<ChromeSearchResult>(
- new SearchWebstoreResult(profile_, query_)).Pass();
-}
-
-ChromeSearchResultType SearchWebstoreResult::GetType() {
- return WEBSTORE_SEARCH_RESULT;
+scoped_ptr<SearchResult> SearchWebstoreResult::Duplicate() {
+ return scoped_ptr<SearchResult>(new SearchWebstoreResult(profile_, query_));
}
} // namespace app_list

Powered by Google App Engine
This is Rietveld 408576698