Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/ui/app_list/search/people/people_result.cc

Issue 621823004: Simplifies the structure of app_list search a bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/people/people_result.cc
diff --git a/chrome/browser/ui/app_list/search/people/people_result.cc b/chrome/browser/ui/app_list/search/people/people_result.cc
index 57ae19fdbbec5103bf840c808031daac145235a9..6278313bf226a3d15677b9273235589d3ce51ada 100644
--- a/chrome/browser/ui/app_list/search/people/people_result.cc
+++ b/chrome/browser/ui/app_list/search/people/people_result.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/ui/app_list/search/common/url_icon_source.h"
#include "chrome/browser/ui/app_list/search/people/person.h"
+#include "chrome/browser/ui/app_list/search/search_util.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/common/extensions/api/hangouts_private.h"
#include "chrome/grit/generated_resources.h"
@@ -86,6 +87,8 @@ PeopleResult::~PeopleResult() {
}
void PeopleResult::Open(int event_flags) {
+ RecordHistogram(SEARCH_PEOPLE_SEARCH_RESULT);
+
// Action 0 will always be our default action.
InvokeAction(0, event_flags);
}
@@ -109,9 +112,9 @@ void PeopleResult::InvokeAction(int action_index, int event_flags) {
}
}
-scoped_ptr<ChromeSearchResult> PeopleResult::Duplicate() {
- return scoped_ptr<ChromeSearchResult>(
- new PeopleResult(profile_, person_->Duplicate().Pass())).Pass();
+scoped_ptr<SearchResult> PeopleResult::Duplicate() {
+ return scoped_ptr<SearchResult>(
+ new PeopleResult(profile_, person_->Duplicate().Pass()));
}
void PeopleResult::OnIconLoaded() {
@@ -194,8 +197,4 @@ void PeopleResult::RefreshHangoutsExtensionId() {
hangouts_extension_id_.clear();
}
-ChromeSearchResultType PeopleResult::GetType() {
- return SEARCH_PEOPLE_SEARCH_RESULT;
-}
-
} // namespace app_list
« no previous file with comments | « chrome/browser/ui/app_list/search/people/people_result.h ('k') | chrome/browser/ui/app_list/search/search_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698