Simplifies the structure of app_list search a bit.

athena/home/app_list_view_delegate.cc

Index: athena/home/app_list_view_delegate.cc
diff --git a/athena/home/app_list_view_delegate.cc b/athena/home/app_list_view_delegate.cc
index 99b1041cf1057e1cc99dfeef467e80a5cfc67176..29ecb0574e4bc6d95041d912c240d46a7bc65050 100644
--- a/athena/home/app_list_view_delegate.cc
+++ b/athena/home/app_list_view_delegate.cc
@@ -53,14 +53,10 @@ void AppListViewDelegate::RegisterSearchProvider(
 void AppListViewDelegate::SearchResultChanged() {
   // TODO(mukai): port app-list's Mixer to reorder the results properly.
   app_list::SearchProvider* search_provider = search_providers_[0];
-  std::vector<app_list::SearchResult*> results;
-  search_provider->ReleaseResult(&results);
-  if (results.empty()) {
-    model_->results()->DeleteAll();
-  } else {
-    for (size_t i = 0; i < results.size(); ++i)
-      model_->results()->Add(results[i]);
-  }
+  const app_list::SearchProvider::Results& results = search_provider->results();
+  model_->results()->DeleteAll();

[tapted, 2014/10/02 07:19:21]

Does this cause flickering of the search results in some cases? I think mixer.cc
has special code to prevent this, but it might not affect Athena

[Jun Mukai, 2014/10/03 01:24:23]

Right, this actually causes flickering unfortunately.
I don't care much about this because the current code is hacky anyways. I will
move mixer ui/app_list and use it from here later.

+  for (size_t i = 0; i < results.size(); ++i)
+    model_->results()->Add(results[i]->Duplicate().release());

[tapted, 2014/10/02 07:19:21]

(no action required) would be nice if this .release() could be a .Pass() but I
guess ListModel doesn't support that :/

Moving the SearchResults typedef and having
`SearchResult::CopyToList(SearchResults* result_list);` might be another option
(and here: `results[i]->CopyToList(&model_->results())`), but it's a bit
backward.

A third option: AppListModel::AddSearchResult?

But what's here is fine.

[Jun Mukai, 2014/10/03 01:24:23]

Agreed. I think ideally ListModel should support it...

 }
 
 bool AppListViewDelegate::ForceNativeDesktop() const {