Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/ui/app_list/search/search_controller.cc

Issue 621823004: Simplifies the structure of app_list search a bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/app_list/search/search_controller.h" 5 #include "chrome/browser/ui/app_list/search/search_controller.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/metrics/histogram.h" 13 #include "base/metrics/histogram.h"
14 #include "base/strings/string_util.h" 14 #include "base/strings/string_util.h"
15 #include "base/strings/utf_string_conversions.h" 15 #include "base/strings/utf_string_conversions.h"
16 #include "chrome/browser/profiles/profile.h" 16 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h" 17 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
18 #include "chrome/browser/ui/app_list/search/app_search_provider.h" 18 #include "chrome/browser/ui/app_list/search/app_search_provider.h"
19 #include "chrome/browser/ui/app_list/search/chrome_search_result.h"
20 #include "chrome/browser/ui/app_list/search/history.h" 19 #include "chrome/browser/ui/app_list/search/history.h"
21 #include "chrome/browser/ui/app_list/search/history_factory.h" 20 #include "chrome/browser/ui/app_list/search/history_factory.h"
22 #include "chrome/browser/ui/app_list/search/omnibox_provider.h" 21 #include "chrome/browser/ui/app_list/search/omnibox_provider.h"
23 #include "chrome/browser/ui/app_list/search/people/people_provider.h" 22 #include "chrome/browser/ui/app_list/search/people/people_provider.h"
24 #include "chrome/browser/ui/app_list/search/webstore/webstore_provider.h" 23 #include "chrome/browser/ui/app_list/search/webstore/webstore_provider.h"
25 #include "chrome/browser/ui/app_list/start_page_service.h" 24 #include "chrome/browser/ui/app_list/start_page_service.h"
26 #include "chrome/common/chrome_switches.h" 25 #include "chrome/common/chrome_switches.h"
27 #include "chrome/grit/generated_resources.h" 26 #include "chrome/grit/generated_resources.h"
28 #include "content/public/browser/user_metrics.h" 27 #include "content/public/browser/user_metrics.h"
29 #include "grit/components_scaled_resources.h" 28 #include "grit/components_scaled_resources.h"
30 #include "grit/theme_resources.h" 29 #include "grit/theme_resources.h"
31 #include "ui/app_list/search_box_model.h" 30 #include "ui/app_list/search_box_model.h"
31 #include "ui/app_list/search_result.h"
32 #include "ui/app_list/speech_ui_model.h" 32 #include "ui/app_list/speech_ui_model.h"
33 #include "ui/base/l10n/l10n_util.h" 33 #include "ui/base/l10n/l10n_util.h"
34 #include "ui/base/resource/resource_bundle.h" 34 #include "ui/base/resource/resource_bundle.h"
35 35
36 namespace { 36 namespace {
37 const char kAppListSearchResultOpenTypeHistogram[] = 37 const char kAppListSearchResultOpenTypeHistogram[] =
38 "Apps.AppListSearchResultOpenType"; 38 "Apps.AppListSearchResultOpenType";
39 39
40 // Maximum time (in milliseconds) to wait to the search providers to finish. 40 // Maximum time (in milliseconds) to wait to the search providers to finish.
41 const int kStopTimeMS = 1500; 41 const int kStopTimeMS = 1500;
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 it != providers_.end(); 126 it != providers_.end();
127 ++it) { 127 ++it) {
128 (*it)->Stop(); 128 (*it)->Stop();
129 } 129 }
130 } 130 }
131 131
132 void SearchController::OpenResult(SearchResult* result, int event_flags) { 132 void SearchController::OpenResult(SearchResult* result, int event_flags) {
133 // Count AppList.Search here because it is composed of search + action. 133 // Count AppList.Search here because it is composed of search + action.
134 content::RecordAction(base::UserMetricsAction("AppList_Search")); 134 content::RecordAction(base::UserMetricsAction("AppList_Search"));
135 135
136 ChromeSearchResult* chrome_result =
137 static_cast<app_list::ChromeSearchResult*>(result);
138 UMA_HISTOGRAM_ENUMERATION(kAppListSearchResultOpenTypeHistogram, 136 UMA_HISTOGRAM_ENUMERATION(kAppListSearchResultOpenTypeHistogram,
139 chrome_result->GetType(), 137 result->GetType(),
140 SEARCH_RESULT_TYPE_BOUNDARY); 138 SEARCH_RESULT_TYPE_BOUNDARY);
141 chrome_result->Open(event_flags); 139 result->Open(event_flags);
142 140
143 if (history_ && history_->IsReady()) { 141 if (history_ && history_->IsReady()) {
144 history_->AddLaunchEvent(base::UTF16ToUTF8(search_box_->text()), 142 history_->AddLaunchEvent(base::UTF16ToUTF8(search_box_->text()),
145 chrome_result->id()); 143 result->id());
146 } 144 }
147 } 145 }
148 146
149 void SearchController::InvokeResultAction(SearchResult* result, 147 void SearchController::InvokeResultAction(SearchResult* result,
150 int action_index, 148 int action_index,
151 int event_flags) { 149 int event_flags) {
152 // TODO(xiyuan): Hook up with user learning. 150 // TODO(xiyuan): Hook up with user learning.
153 static_cast<app_list::ChromeSearchResult*>(result)->InvokeAction( 151 result->InvokeAction(action_index, event_flags);
154 action_index, event_flags);
155 } 152 }
156 153
157 void SearchController::AddProvider(Mixer::GroupId group, 154 void SearchController::AddProvider(Mixer::GroupId group,
158 scoped_ptr<SearchProvider> provider) { 155 scoped_ptr<SearchProvider> provider) {
159 provider->set_result_changed_callback(base::Bind( 156 provider->set_result_changed_callback(base::Bind(
160 &SearchController::OnResultsChanged, 157 &SearchController::OnResultsChanged,
161 base::Unretained(this))); 158 base::Unretained(this)));
162 mixer_->AddProviderToGroup(group, provider.get()); 159 mixer_->AddProviderToGroup(group, provider.get());
163 providers_.push_back(provider.release()); // Takes ownership. 160 providers_.push_back(provider.release()); // Takes ownership.
164 } 161 }
(...skipping 12 matching lines...) Expand all
177 } 174 }
178 175
179 void SearchController::OnSpeechRecognitionStateChanged( 176 void SearchController::OnSpeechRecognitionStateChanged(
180 SpeechRecognitionState new_state) { 177 SpeechRecognitionState new_state) {
181 search_box_->SetHintText(l10n_util::GetStringUTF16( 178 search_box_->SetHintText(l10n_util::GetStringUTF16(
182 (new_state == SPEECH_RECOGNITION_HOTWORD_LISTENING) ? 179 (new_state == SPEECH_RECOGNITION_HOTWORD_LISTENING) ?
183 IDS_SEARCH_BOX_HOTWORD_HINT : IDS_SEARCH_BOX_HINT)); 180 IDS_SEARCH_BOX_HOTWORD_HINT : IDS_SEARCH_BOX_HINT));
184 } 181 }
185 182
186 } // namespace app_list 183 } // namespace app_list
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698