Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 621773002: [Base] Use variadic template for helpers in bind_internal.h (wave 2) (Closed)

Created:
6 years, 2 months ago by tzik
Modified:
6 years, 1 month ago
Reviewers:
awong
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@01_landing
Project:
chromium
Visibility:
Public.

Description

[Base] Use variadic template for helpers in bind_internal.h This CL removes generated code for * RunnableAdapter * ForceVoidReturn * FunctorTraits * InvokeHelper from base/bind_internal.h. BUG=433164 Committed: https://crrev.com/c821499285f70fac3090ff79850a0f2fdacec870 Cr-Commit-Position: refs/heads/master@{#304997}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -869 lines) Patch
M base/bind_internal.h View 1 5 chunks +41 lines, -787 lines 0 comments Download
M base/bind_internal.h.pump View 1 5 chunks +41 lines, -82 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tzik
PTL. This is another easy part that depends on the callback.h update.
6 years, 2 months ago (2014-10-08 15:59:55 UTC) #2
awong
LGTM This one might even make build times drop. :D
6 years, 2 months ago (2014-10-08 16:01:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621773002/40001
6 years, 1 month ago (2014-11-20 08:42:31 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 10:09:51 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 10:10:44 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c821499285f70fac3090ff79850a0f2fdacec870
Cr-Commit-Position: refs/heads/master@{#304997}

Powered by Google App Engine
This is Rietveld 408576698