Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 621763003: Temporarily exclude extension_tab_util impl (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Temporarily exclude extension_tab_util impl BUG=414340 Remove Committed: https://crrev.com/b70d0f81d18b6c028733772b25b3b54f4dfc1f67 Cr-Commit-Position: refs/heads/master@{#297767}

Patch Set 1 #

Patch Set 2 : gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -4 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_tab_util_athena.cc View 1 chunk +174 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
oshima
excluding another path to tab creation. ptal.
6 years, 2 months ago (2014-10-01 20:52:14 UTC) #2
Yoyo Zhou
LGTM, I like the gyp deduplication too.
6 years, 2 months ago (2014-10-01 20:58:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621763003/1
6 years, 2 months ago (2014-10-01 22:34:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621763003/20001
6 years, 2 months ago (2014-10-02 00:03:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0f30e36c39d4da6934688bdef3cf1dfa48d7a0a4
6 years, 2 months ago (2014-10-02 02:11:34 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 02:12:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b70d0f81d18b6c028733772b25b3b54f4dfc1f67
Cr-Commit-Position: refs/heads/master@{#297767}

Powered by Google App Engine
This is Rietveld 408576698