Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 62173003: Linux: fix build with gnome-keyring on Aura. (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.
Modified:
7 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: fix build with gnome-keyring on Aura. This is upstreaming a Gentoo Linux patch. BUG=none R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235446

Patch Set 1 #

Patch Set 2 : trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-15 00:35:05 UTC) #1
Elliot Glaysher
lgtm
7 years, 1 month ago (2013-11-15 02:15:36 UTC) #2
Paweł Hajdan Jr.
PTAL - I needed to modify common.gypi to avoid gyp on mac trying to use ...
7 years, 1 month ago (2013-11-15 19:35:43 UTC) #3
Elliot Glaysher
lgtm
7 years, 1 month ago (2013-11-15 20:04:01 UTC) #4
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-15 22:00:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r235446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698