Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 621683003: Fix unit test memory leaks following blink r183043 (Closed)

Created:
6 years, 2 months ago by jsbell
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford, pastarmovj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix unit test memory leaks following blink r183043 Garbage collection was enabled on the blink side for DOMError objects, which were created by the IndexedDBDispatcher tests. Add in the appropriate GC calls at test tear-down. BUG=419418 R=haraken@chromium.org,cmumford@chromium.org Committed: https://crrev.com/39e68d9d77a45311e05b03cf0821e20c1a410850 Cr-Commit-Position: refs/heads/master@{#297677}

Patch Set 1 #

Total comments: 2

Patch Set 2 : OVERRIDE -> override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
cmumford
https://codereview.chromium.org/621683003/diff/1/content/child/indexed_db/indexed_db_dispatcher_unittest.cc File content/child/indexed_db/indexed_db_dispatcher_unittest.cc (right): https://codereview.chromium.org/621683003/diff/1/content/child/indexed_db/indexed_db_dispatcher_unittest.cc#newcode71 content/child/indexed_db/indexed_db_dispatcher_unittest.cc:71: virtual void TearDown() OVERRIDE { In light of http://chromium-cpp.appspot.com/ ...
6 years, 2 months ago (2014-10-01 17:22:35 UTC) #1
jsbell
https://codereview.chromium.org/621683003/diff/1/content/child/indexed_db/indexed_db_dispatcher_unittest.cc File content/child/indexed_db/indexed_db_dispatcher_unittest.cc (right): https://codereview.chromium.org/621683003/diff/1/content/child/indexed_db/indexed_db_dispatcher_unittest.cc#newcode71 content/child/indexed_db/indexed_db_dispatcher_unittest.cc:71: virtual void TearDown() OVERRIDE { On 2014/10/01 17:22:35, cmumford ...
6 years, 2 months ago (2014-10-01 17:24:56 UTC) #2
cmumford
lgtm
6 years, 2 months ago (2014-10-01 17:27:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621683003/20001
6 years, 2 months ago (2014-10-01 17:46:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e42e1f7e3889bb7ed4be5daa639817debf695dfa
6 years, 2 months ago (2014-10-01 18:33:04 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/39e68d9d77a45311e05b03cf0821e20c1a410850 Cr-Commit-Position: refs/heads/master@{#297677}
6 years, 2 months ago (2014-10-01 18:33:42 UTC) #7
haraken
6 years, 2 months ago (2014-10-01 23:25:45 UTC) #9
Message was sent while issue was closed.
LGTM, thanks for fixing this!

Powered by Google App Engine
This is Rietveld 408576698