Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: Source/platform/scroll/ScrollableArea.h

Issue 621653002: Don't call into ScrollView from Scrollbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@resizer
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/scroll/ScrollView.cpp ('k') | Source/platform/scroll/Scrollbar.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 { 151 {
152 return scrollbar->Widget::convertToContainingView(scrollbarPoint); 152 return scrollbar->Widget::convertToContainingView(scrollbarPoint);
153 } 153 }
154 virtual IntPoint convertFromContainingViewToScrollbar(const Scrollbar* scrol lbar, const IntPoint& parentPoint) const 154 virtual IntPoint convertFromContainingViewToScrollbar(const Scrollbar* scrol lbar, const IntPoint& parentPoint) const
155 { 155 {
156 return scrollbar->Widget::convertFromContainingView(parentPoint); 156 return scrollbar->Widget::convertFromContainingView(parentPoint);
157 } 157 }
158 158
159 virtual Scrollbar* horizontalScrollbar() const { return 0; } 159 virtual Scrollbar* horizontalScrollbar() const { return 0; }
160 virtual Scrollbar* verticalScrollbar() const { return 0; } 160 virtual Scrollbar* verticalScrollbar() const { return 0; }
161 virtual bool isScrollViewScrollbar(const Widget* child) const { return false ; }
161 162
162 // scrollPosition is relative to the scrollOrigin. i.e. If the page is RTL 163 // scrollPosition is relative to the scrollOrigin. i.e. If the page is RTL
163 // then scrollPosition will be negative. By default, scrollPositionDouble() 164 // then scrollPosition will be negative. By default, scrollPositionDouble()
164 // just call into scrollPosition(). Subclass can override scrollPositionDoub le() 165 // just call into scrollPosition(). Subclass can override scrollPositionDoub le()
165 // to return floating point precision scrolloffset. 166 // to return floating point precision scrolloffset.
166 // FIXME: Remove scrollPosition(). crbug.com/414283. 167 // FIXME: Remove scrollPosition(). crbug.com/414283.
167 virtual IntPoint scrollPosition() const = 0; 168 virtual IntPoint scrollPosition() const = 0;
168 virtual DoublePoint scrollPositionDouble() const { return DoublePoint(scroll Position()); } 169 virtual DoublePoint scrollPositionDouble() const { return DoublePoint(scroll Position()); }
169 virtual IntPoint minimumScrollPosition() const = 0; 170 virtual IntPoint minimumScrollPosition() const = 0;
170 virtual IntPoint maximumScrollPosition() const = 0; 171 virtual IntPoint maximumScrollPosition() const = 0;
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 // vertical-lr / ltr NO NO 308 // vertical-lr / ltr NO NO
308 // vertical-lr / rtl NO YES 309 // vertical-lr / rtl NO YES
309 // vertical-rl / ltr YES NO 310 // vertical-rl / ltr YES NO
310 // vertical-rl / rtl YES YES 311 // vertical-rl / rtl YES YES
311 IntPoint m_scrollOrigin; 312 IntPoint m_scrollOrigin;
312 }; 313 };
313 314
314 } // namespace blink 315 } // namespace blink
315 316
316 #endif // ScrollableArea_h 317 #endif // ScrollableArea_h
OLDNEW
« no previous file with comments | « Source/platform/scroll/ScrollView.cpp ('k') | Source/platform/scroll/Scrollbar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698