Issue 62159: Remove superfluous depends now that WebString isn't in IPC anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62159: Remove superfluous depends now that WebString isn't in IPC anymore. (Closed)

Created:
11 years, 8 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove superfluous depends now that WebString isn't in IPC anymore. r12881 added WebKit API functions to renderer messages. This required linking in huge numbers of new libraries into many Linux and Mac targets. WebString has since been removed and this is an attempt to undo r12892 for Linux. The original changes cannot be reverted since Linux has since moved from scons to GYP. This passes try servers on all platforms. BUG=9586

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	chrome/chrome.gyp	View		3 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

11 years, 8 months ago (2009-04-08 20:05:01 UTC) #2

LGTM.   Thanks for following up.

Can we also move breakpad back out of the renderer library and into only the
app?  (See  http://codereview.chromium.org/56119)

Expand Messages | Collapse Messages