Omnibox: Fix Inline Autocompletion of Navsuggest in Forced Query Mode

Omnibox: Fix Inline Autocompletion of Navsuggest in Forced Query Mode

This moves the block of code that adds the "?" from one place to another.
Its original location was wrong because it incremented
|inline_autocomplete_offset| before passing it to FormatUrl().
This could change how FormatUrl() would correct inline_autocomplete_offset
when its value is near the end of the formatted string.
This is wrong.

In both locations, in effect we are adding the "?" prefix after FormatUrl()
runs.  This means we should correct the inline_autocomplete_offset value
to compensate for the extra character "?" only after FormatUrl() runs.

This fixes the bug.

I also added a test that would've caught this issue.

BUG=313451
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233544

[Mark P, 2013-11-06 15:52:24]

Simple.  I'm not sure my code review explanation is clear, but regardless you
should be easily able to review and approve the code.

--mark

[Peter Kasting, 2013-11-06 19:55:42]

LGTM

[commit-bot: I haz the power, 2013-11-06 23:33:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/62153002/20001

[commit-bot: I haz the power, 2013-11-07 08:14:28]

Change committed as 233544