Exclude readonly and disabled elements from autofill form.

components/autofill/content/renderer/form_autofill_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 707 matching lines @@
 void ExtractAutofillableElements(
     const WebFormElement& form_element,
     RequirementsMask requirements,
     std::vector<WebFormControlElement>* autofillable_elements) {
   WebVector<WebFormControlElement> control_elements;
   form_element.getFormControlElements(control_elements);
 
   autofillable_elements->clear();
   for (size_t i = 0; i < control_elements.size(); ++i) {
     WebFormControlElement element = control_elements[i];
-    if (!IsAutofillableElement(element))
+    if (!IsAutofillableElement(element) ||
+        element.isReadOnly() ||
+        !element.isEnabled())

[Mike West, 2014/10/02 12:49:57]

Why not fold this into IsAutofillable{Input?}Element?

       continue;
 
     if (requirements & REQUIRE_AUTOCOMPLETE) {
       // TODO(isherman): WebKit currently doesn't handle the autocomplete
       // attribute for select or textarea elements, but it probably should.
       WebInputElement* input_element = toWebInputElement(&control_elements[i]);
       if (IsAutofillableInputElement(input_element) &&
           !SatisfiesRequireAutocomplete(*input_element))
         continue;
     }
@@ skipping 120 matching lines @@
   WebVector<WebFormControlElement> control_elements;
   form_element.getFormControlElements(control_elements);
 
   // A vector of bools that indicate whether each field in the form meets the
   // requirements and thus will be in the resulting |form|.
   std::vector<bool> fields_extracted(control_elements.size(), false);
 
   for (size_t i = 0; i < control_elements.size(); ++i) {
     const WebFormControlElement& control_element = control_elements[i];
 
-    if (!IsAutofillableElement(control_element))
+    if (!IsAutofillableElement(control_element) ||
+        control_element.isReadOnly() ||
+        !control_element.isEnabled())
       continue;
 
     const WebInputElement* input_element = toWebInputElement(&control_element);
     if (requirements & REQUIRE_AUTOCOMPLETE &&
         IsAutofillableInputElement(input_element) &&
         !SatisfiesRequireAutocomplete(*input_element))
       continue;
 
     // Create a new FormFieldData, fill it out and map it to the field's name.
     FormFieldData* form_field = new FormFieldData;
@@ skipping 274 matching lines @@
 
 gfx::RectF GetScaledBoundingBox(float scale, WebFormControlElement* element) {
   gfx::Rect bounding_box(element->boundsInViewportSpace());
   return gfx::RectF(bounding_box.x() * scale,
                     bounding_box.y() * scale,
                     bounding_box.width() * scale,
                     bounding_box.height() * scale);
 }
 
 }  // namespace autofill