Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 62143002: Add three string constants from parser to the root-set. (Closed)

Created:
7 years, 1 month ago by Michael Starzinger
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add three string constants from parser to the root-set. R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/func-name-inferrer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/parser.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M src/rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 1 month ago (2013-11-06 15:47:40 UTC) #1
ulan
lgtm
7 years, 1 month ago (2013-11-06 15:49:52 UTC) #2
Michael Starzinger
7 years, 1 month ago (2013-11-06 17:06:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17531 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698