Fix for a regression introduced by an autofill change

One of my recent CL added triggering form autofill when clicking an already focused text-field.
It was triggering form autofill or password autofill indiscriminately, causing a regression: double clicking a login text-field would trigger password autofill preventing the expected behavior of selecting the text in the text-field.  Only form autofill is expected to be triggered in that case.

BUG=9544
TEST=Open a page with a login form for which you have saved a password. Double-click the login text-field, this should select all the text. Ensure the form autocomplete still works as expected.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13408

[tim (not reviewing), 2009-04-08 23:38:35]

http://codereview.chromium.org/62143/diff/2001/9
File webkit/glue/editor_client_impl.cc (right):

http://codereview.chromium.org/62143/diff/2001/9#newcode745
Line 745: return;  // Don't trigger form-autofill on login forms.
you mean don't trigger password autocomplete in response to a form autofill
event like keyup/down/click? but wait.. your CL desc says form autofill should
be triggered in this case? Maybe I'm still a tad confused..

[jcampan, 2009-04-09 00:15:14]

http://codereview.chromium.org/62143/diff/2001/9
File webkit/glue/editor_client_impl.cc (right):

http://codereview.chromium.org/62143/diff/2001/9#newcode745
Line 745: return;  // Don't trigger form-autofill on login forms.
On 2009/04/08 23:38:35, timsteele wrote:
> you mean don't trigger password autocomplete in response to a form autofill
> event like keyup/down/click? but wait.. your CL desc says form autofill should
> be triggered in this case? Maybe I'm still a tad confused..
You are right. This comment sucks. I changed the param to form_autofill_only, I
think that make that line self-explanatory.
Yes we should trigger form autofill if the user keyup/down/click on a
text-field, unless it has a password listener. I think having both behaviors on
the same node might be confusing.

[tim (not reviewing), 2009-04-09 01:58:07]

LGTM