Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 62133002: Cleanup of branch code generation (no change in functionality). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_x64.cc (revision 30039)
+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)
@@ -1640,38 +1640,6 @@
}
-void FlowGraphCompiler::EmitDoubleCompareBranch(Condition true_condition,
- FpuRegister left,
- FpuRegister right,
- BranchInstr* branch) {
- ASSERT(branch != NULL);
- assembler()->comisd(left, right);
- BlockEntryInstr* nan_result = (true_condition == NOT_EQUAL) ?
- branch->true_successor() : branch->false_successor();
- assembler()->j(PARITY_EVEN, GetJumpLabel(nan_result));
- branch->EmitBranchOnCondition(this, true_condition);
-}
-
-
-void FlowGraphCompiler::EmitDoubleCompareBool(Condition true_condition,
- FpuRegister left,
- FpuRegister right,
- Register result) {
- assembler()->comisd(left, right);
- Label is_false, is_true, done;
- // x == NaN -> false, x != NaN -> true.
- Label* nan_label = (true_condition == NOT_EQUAL) ? &is_true : &is_false;
- assembler()->j(PARITY_EVEN, nan_label, Assembler::kNearJump);
- assembler()->j(true_condition, &is_true, Assembler::kNearJump);
- assembler()->Bind(&is_false);
- assembler()->LoadObject(result, Bool::False(), PP);
- assembler()->jmp(&done);
- assembler()->Bind(&is_true);
- assembler()->LoadObject(result, Bool::True(), PP);
- assembler()->Bind(&done);
-}
-
-
FieldAddress FlowGraphCompiler::ElementAddressForIntIndex(intptr_t cid,
intptr_t index_scale,
Register array,
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698