Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 62133002: Cleanup of branch code generation (no change in functionality). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm.cc (revision 30039)
+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)
@@ -1599,40 +1599,6 @@
}
-void FlowGraphCompiler::EmitDoubleCompareBranch(Condition true_condition,
- FpuRegister left,
- FpuRegister right,
- BranchInstr* branch) {
- ASSERT(branch != NULL);
- DRegister dleft = EvenDRegisterOf(left);
- DRegister dright = EvenDRegisterOf(right);
- assembler()->vcmpd(dleft, dright);
- assembler()->vmstat();
- BlockEntryInstr* nan_result = (true_condition == NE) ?
- branch->true_successor() : branch->false_successor();
- assembler()->b(GetJumpLabel(nan_result), VS);
- branch->EmitBranchOnCondition(this, true_condition);
-}
-
-
-void FlowGraphCompiler::EmitDoubleCompareBool(Condition true_condition,
- FpuRegister left,
- FpuRegister right,
- Register result) {
- DRegister dleft = EvenDRegisterOf(left);
- DRegister dright = EvenDRegisterOf(right);
- assembler()->vcmpd(dleft, dright);
- assembler()->vmstat();
- assembler()->LoadObject(result, Bool::False());
- Label done;
- if (true_condition != NE) {
- assembler()->b(&done, VS); // x == NaN -> false, x != NaN -> true.
- }
- assembler()->LoadObject(result, Bool::True(), true_condition);
- assembler()->Bind(&done);
-}
-
-
// Do not implement or use this function.
FieldAddress FlowGraphCompiler::ElementAddressForIntIndex(intptr_t cid,
intptr_t index_scale,
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698