Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 62131: Ask for user confirmation when closing a browser with in-progress downloads (Closed)

Created:
11 years, 8 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This CL adds a confirmation box when closing the browser with in-progress downloads. BUG=1028 TEST=Start several bug downloads, close the browser. A dialog shows up to warn you are about to lose the downloads. Try the wait and continue button. Try again with several windows, and in Incognito mode. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13453

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 12

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/browser.h View 1 2 3 4 5 6 3 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/browser.cc View 1 2 3 4 5 6 5 chunks +73 lines, -3 lines 0 comments Download
M chrome/browser/browser_window.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.h View 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 2 3 4 5 6 4 chunks +76 lines, -0 lines 0 comments Download
M chrome/test/test_browser_window.h View 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jcampan
11 years, 8 months ago (2009-04-08 00:32:59 UTC) #1
sky
http://codereview.chromium.org/62131/diff/1036/18 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/62131/diff/1036/18#newcode1347 Line 1347: You have <ph name="DOWNLOAD_COUNT">$1<ex>3</ex></ph> download(s) in progress. If ...
11 years, 8 months ago (2009-04-08 17:35:45 UTC) #2
jcampan
OK, per our discussion, I made the call to confirm the browser closure non blocking. ...
11 years, 8 months ago (2009-04-08 22:32:08 UTC) #3
sky
My only comment is the one mentioned in person. Seems like we should not consider ...
11 years, 8 months ago (2009-04-09 00:07:15 UTC) #4
jcampan
Regarding the app windows, it seems they just behave as a regular browser window. So ...
11 years, 8 months ago (2009-04-09 07:06:26 UTC) #5
sky
11 years, 8 months ago (2009-04-09 19:46:28 UTC) #6
I was thinking we wanted something more complicated for app windows, but on
second thought it's too confusing. So, LGTM.

Powered by Google App Engine
This is Rietveld 408576698